weak_intrusive_ptr#10038

Closed

smessmer wants to merge 2 commits intopytorch:masterfrom

smessmer:export-D9039980

Contributor

smessmer commented Jul 30, 2018

Summary: Add weak_ptr ability to intrusive_ptr.

Differential Revision: D9039980

smessmer requested review from apaszke, colesbury, ezyang, gchanan, soumith and zdevito as code owners

July 30, 2018 23:22

smessmer force-pushed the export-D9039980 branch from dffdfe4 to 643c308 Compare

July 31, 2018 01:12

smessmer force-pushed the export-D9039980 branch from 643c308 to ac59a7e Compare

July 31, 2018 01:17

ezyang reviewed

View reviewed changes

aten/src/ATen/core/intrusive_ptr.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/core/intrusive_ptr.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/core/intrusive_ptr.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/core/intrusive_ptr.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/core/intrusive_ptr.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/core/intrusive_ptr.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/core/intrusive_ptr.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/core/intrusive_ptr.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/core/intrusive_ptr.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/core/intrusive_ptr.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

smessmer force-pushed the export-D9039980 branch from ac59a7e to d9c5390 Compare

July 31, 2018 17:53

smessmer force-pushed the export-D9039980 branch from d9c5390 to 7636620 Compare

July 31, 2018 17:58

smessmer force-pushed the export-D9039980 branch from 7636620 to 6f41e73 Compare

July 31, 2018 20:17

smessmer force-pushed the export-D9039980 branch from 6f41e73 to 928256e Compare

July 31, 2018 20:22

smessmer force-pushed the export-D9039980 branch from 928256e to b6a7479 Compare

July 31, 2018 21:30

smessmer requested a review from anderspapitto as a code owner

July 31, 2018 21:30

smessmer force-pushed the export-D9039980 branch from 9fad7b4 to 7023c7e Compare

July 31, 2018 22:52

smessmer force-pushed the export-D9039980 branch from 7023c7e to c8a8db9 Compare

August 1, 2018 15:37

smessmer force-pushed the export-D9039980 branch from c8a8db9 to 4d2e976 Compare

August 1, 2018 17:11

smessmer force-pushed the export-D9039980 branch from 4d2e976 to 2df4eeb Compare

August 1, 2018 17:20

smessmer force-pushed the export-D9039980 branch from 2df4eeb to 6625988 Compare

August 1, 2018 18:00

smessmer force-pushed the export-D9039980 branch from 6625988 to 468914d Compare

August 1, 2018 18:47

smessmer force-pushed the export-D9039980 branch from 468914d to a062411 Compare

August 1, 2018 20:48

smessmer force-pushed the export-D9039980 branch from a062411 to 8155255 Compare

August 1, 2018 22:25

smessmer force-pushed the export-D9039980 branch from 8155255 to b490bcf Compare

August 1, 2018 23:51

smessmer force-pushed the export-D9039980 branch from b490bcf to 031913e Compare

August 2, 2018 17:06

smessmer added 2 commits

August 2, 2018 15:26


          IntrusivePtr

3fccb45

Summary: Add an IntrusivePtr class to do intrusive refcounting with a shared_ptr-like interface.

Differential Revision: D9018619

fbshipit-source-id: 83d6eae6f39dc67d98b2b45dc18e9ccdbbcb2e5e


          weak_intrusive_ptr (pytorch#10038)

65c51cc

Summary:
Pull Request resolved: pytorch#10038

Add weak_ptr ability to intrusive_ptr.

Differential Revision: D9039980

fbshipit-source-id: 58bd73f5704643b8bca799de1812d7aa5d4a44cb

smessmer force-pushed the export-D9039980 branch from 031913e to 65c51cc Compare

August 2, 2018 22:26

facebook-github-bot closed this in

798b530

zdevito pushed a commit to zdevito/ATen that referenced this pull request


          weak_intrusive_ptr (#10038)

04933da

Summary:
Pull Request resolved: pytorch/pytorch#10038

Add weak_ptr ability to intrusive_ptr.

Reviewed By: ezyang

Differential Revision: D9039980

fbshipit-source-id: dd504d6e0d7acf5914cd45845355e28f9df201fb

goodlux pushed a commit to goodlux/pytorch that referenced this pull request


          weak_intrusive_ptr (pytorch#10038)

e9c3fc7

Summary:
Pull Request resolved: pytorch#10038

Add weak_ptr ability to intrusive_ptr.

Reviewed By: ezyang

Differential Revision: D9039980

fbshipit-source-id: dd504d6e0d7acf5914cd45845355e28f9df201fb

ezyang added the merged label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ezyang ezyang left review comments

apaszke Awaiting requested review from apaszke

colesbury Awaiting requested review from colesbury

gchanan Awaiting requested review from gchanan

soumith Awaiting requested review from soumith

zdevito Awaiting requested review from zdevito

anderspapitto Awaiting requested review from anderspapitto

bddppq Awaiting requested review from bddppq

dzhulgakov Awaiting requested review from dzhulgakov

ebetica Awaiting requested review from ebetica

goldsborough Awaiting requested review from goldsborough

houseroad Awaiting requested review from houseroad

jamesr66a Awaiting requested review from jamesr66a

pietern Awaiting requested review from pietern

teng-li Awaiting requested review from teng-li

Yangqing Awaiting requested review from Yangqing

Labels

None yet