Refactor Seq2SeqModelCaffe2EnsembleDecoder#10035
Closed
pritamdamania87 wants to merge 1 commit intopytorch:masterfrom
pritamdamania87:export-D9026372
Closed
Refactor Seq2SeqModelCaffe2EnsembleDecoder#10035pritamdamania87 wants to merge 1 commit intopytorch:masterfrom pritamdamania87:export-D9026372
pritamdamania87 wants to merge 1 commit intopytorch:masterfrom
pritamdamania87:export-D9026372
Conversation
Contributor
|
@pritamdamania87, looks good, but you probably want to rebase and reexport PR (or alternatively write a comment like "@pytorchbot retest this please") since CI is failing. |
Contributor
|
Oh, it's not failing, we just need to wait more:) |
Summary: Pull Request resolved: #10035 This is an initial diff which refactors some of the components in the Seq2SeqModelCaffe2EnsembleDecoder class. Differential Revision: D9026372 fbshipit-source-id: 8be2fc701230578dafb5de0e57f468605fdcfb17
jmp84
approved these changes
Aug 1, 2018
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10035 This is an initial diff which refactors some of the components in the Seq2SeqModelCaffe2EnsembleDecoder class. Reviewed By: jmp84 Differential Revision: D9026372 fbshipit-source-id: 449635208f24494209ae2fb78a19fca872970ea8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This is an initial diff which refactors some of the components in the Seq2SeqModelCaffe2EnsembleDecoder class.
Differential Revision: D9026372