When BUILD_ATEN=OFF, use ATen/core directly#10019
Closed
ezyang wants to merge 10 commits intopytorch:masterfrom
Closed
When BUILD_ATEN=OFF, use ATen/core directly#10019ezyang wants to merge 10 commits intopytorch:masterfrom
ezyang wants to merge 10 commits intopytorch:masterfrom
Conversation
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
orionr
approved these changes
Jul 30, 2018
| add_subdirectory(../aten/src/ATen/core ATen_core) | ||
| list(APPEND Caffe2_CPU_SRCS ${ATen_CORE_SRCS}) | ||
| list(APPEND Caffe2_CPU_INCLUDE ${ATen_CORE_INCLUDE}) | ||
| # TODO: We should probably install the headers, but I don't know |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| # NB: If you edit these globs, you'll have to update setup.py package_data as well | ||
| FILE(GLOB base_h "*.h" "detail/*.h") | ||
| FILE(GLOB base_cpp "*.cpp" "detail/*.cpp") | ||
| add_subdirectory(core) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 31, 2018
Summary: ATenCore.h is a dummy header to just test that this is working at all. Pull Request resolved: pytorch/pytorch#10019 Reviewed By: smessmer Differential Revision: D9067262 Pulled By: ezyang fbshipit-source-id: 58bab9c0aa83b56335e36b719b9b6505400d8dee
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 31, 2018
Summary: Extracted from pytorch@6276246 and in support of pytorch#10019 cc pjh5 mingzhe09088 ezyang smessmer Pull Request resolved: pytorch#10020 Reviewed By: pjh5 Differential Revision: D9068124 Pulled By: orionr fbshipit-source-id: 4dd4910136a312b6517c65ce8802837108475f89
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 31, 2018
Summary: ATenCore.h is a dummy header to just test that this is working at all. Pull Request resolved: pytorch#10019 Reviewed By: smessmer Differential Revision: D9067262 Pulled By: ezyang fbshipit-source-id: 58bab9c0aa83b56335e36b719b9b6505400d8dee
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Extracted from pytorch@6276246 and in support of pytorch#10019 cc pjh5 mingzhe09088 ezyang smessmer Pull Request resolved: pytorch#10020 Reviewed By: pjh5 Differential Revision: D9068124 Pulled By: orionr fbshipit-source-id: 4dd4910136a312b6517c65ce8802837108475f89
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: ATenCore.h is a dummy header to just test that this is working at all. Pull Request resolved: pytorch#10019 Reviewed By: smessmer Differential Revision: D9067262 Pulled By: ezyang fbshipit-source-id: 58bab9c0aa83b56335e36b719b9b6505400d8dee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATenCore.h is a dummy header to just test that this is working at all.