Errors out when Openmpi < 2.x.x with distributed.#10015
Closed
ailzhang wants to merge 3 commits intopytorch:masterfrom
Closed
Errors out when Openmpi < 2.x.x with distributed.#10015ailzhang wants to merge 3 commits intopytorch:masterfrom
ailzhang wants to merge 3 commits intopytorch:masterfrom
Conversation
added 2 commits
July 29, 2018 14:04
soumith
reviewed
Jul 30, 2018
| // OMPI_* is specific to Openmpi implementation. | ||
| // Openmpi v1.10 segfaults in MPI_Bcast with CUDA buffer. | ||
| if (int(OMPI_MAJOR_VERSION) < 2) { | ||
| throw std::runtime_error("Please use MPI 2.x.x and above for distributed."); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@soumith Did PyTorch deprecate the use of OpenMPI version 1 ? Does that mean to use OpenMPI with PyTorch , it needs to be version 2 ? Both RH 7.5 and Ubuntu 16.04 still ships standard with version 1. |
Collaborator
|
it looks like it, from @ailzhang 's investigations that we never supported OpenMPI v1 correctly. This just enforces error checking better. |
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: This PR fixes pytorch#9418 . Openmpi 1.10 segfaults in MPI_Bcast with CUDA buffer. And it's a retired openmpi version. I've tested on 2.1.1 and 3.0.0 and they work well. Pull Request resolved: pytorch#10015 Reviewed By: soumith Differential Revision: D9088103 Pulled By: ailzhang fbshipit-source-id: fc0a45e5cd016093ef0dbb9f371cbf67170d7045
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #9418 .
Openmpi 1.10 segfaults in MPI_Bcast with CUDA buffer. And it's a retired openmpi version.
I've tested on 2.1.1 and 3.0.0 and they work well.