This repository was archived by the owner on Nov 15, 2022. It is now read-only.
Support label_smoothing for cross_entropy in nestedtensor#452
Closed
jbschlosser wants to merge 1 commit intopytorch:fbsyncfrom
Closed
Support label_smoothing for cross_entropy in nestedtensor#452jbschlosser wants to merge 1 commit intopytorch:fbsyncfrom
jbschlosser wants to merge 1 commit intopytorch:fbsyncfrom
Conversation
Summary: Adds awareness of the new `label_smoothing` functionality in `cross_entropy` added in pytorch/pytorch#63122 to nestedtensor's implementation. Fixes broken test: `test.test_nested_tensor_functional.TestFunctional`. Differential Revision: D30730728 fbshipit-source-id: 34d907b76a1d2058cc7bc7d12c271cc3088a351b
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D30730728 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 2, 2021
Summary: Pull Request resolved: #452 Adds awareness of the new `label_smoothing` functionality in `cross_entropy` added in pytorch/pytorch#63122 to nestedtensor's implementation. Fixes broken test: `test.test_nested_tensor_functional.TestFunctional`. Reviewed By: cpuhrsch Differential Revision: D30730728 fbshipit-source-id: 04f146d6de7f764f165059e4b5654d7f39142e38
Author
|
Closing because this merged I guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds awareness of the new
label_smoothingfunctionality incross_entropyadded in pytorch/pytorch#63122 to nestedtensor's implementation.Fixes broken test:
test.test_nested_tensor_functional.TestFunctional.Differential Revision: D30730728