Invert ConfigLoader -> profiler dependency (take 2) (#271)#278
Closed
gdankel wants to merge 1 commit intopytorch:masterfrom
Closed
Invert ConfigLoader -> profiler dependency (take 2) (#271)#278gdankel wants to merge 1 commit intopytorch:masterfrom
gdankel wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28976077 |
Summary: Pull Request resolved: pytorch#278 Pull Request resolved: pytorch#271 Change direction of dependency from ConfigLoader -> profiler to profiler -> ConfigLoader. This way, the profiler is able to lazily initialize config loader and also move towards the pluggable profiler design. Differential Revision: D28976077 fbshipit-source-id: 1929a3585eb2ad431a50dd850b3450826f49055b
ba08eb4 to
5f9baa8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28976077 |
Contributor
|
This pull request has been merged in 9b5fb40. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #271
Change direction of dependency from ConfigLoader -> profiler to profiler -> ConfigLoader. This way, the profiler is able to lazily initialize config loader and also move towards the pluggable profiler design.
Differential Revision: D28976077