Skip to content

Resize the graph when window resized#140

Merged
guyang3532 merged 2 commits intopytorch:plugin/0.2from
Kingwl:redraw_when_resize
Apr 1, 2021
Merged

Resize the graph when window resized#140
guyang3532 merged 2 commits intopytorch:plugin/0.2from
Kingwl:redraw_when_resize

Conversation

@Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Mar 26, 2021

Fixes #125

This PR added a hooks called useResizeEventDependency as well as some minor style fix.

It exposed a value version who will be increase when the window resized. And we could just put the version into chat dependency list to re-draw the chart when window resized.

@Kingwl Kingwl changed the base branch from master to plugin/0.2 March 31, 2021 06:25
@nbcsm nbcsm requested a review from guyang3532 March 31, 2021 11:59
@nbcsm nbcsm added the plugin PyTorch Profiler TensorBoard Plugin related label Mar 31, 2021
Copy link
Contributor

@nbcsm nbcsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to build index.html?

@Kingwl
Copy link
Contributor Author

Kingwl commented Apr 1, 2021

Yep.
And I strongly recommends to add the github action who automatic build the bundle after push (#52)

@guyang3532 guyang3532 merged commit 1173871 into pytorch:plugin/0.2 Apr 1, 2021
@Kingwl Kingwl deleted the redraw_when_resize branch April 1, 2021 04:07
gaoteng-git pushed a commit to gaoteng-git/kineto that referenced this pull request Apr 25, 2021
 Resize the graph when window resized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed plugin PyTorch Profiler TensorBoard Plugin related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In plugin Overall View, chart does not resize with size of browser window

4 participants