This repository was archived by the owner on Jul 1, 2025. It is now read-only.
Closed
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D31153947 |
khabinov
added a commit
to khabinov/glow
that referenced
this pull request
Sep 23, 2021
Summary: Pull Request resolved: pytorch#5824 After a recent optimization pytorch/pytorch#65014 we started to normalize `aten::rsub` as `aten::sub`, so the test started to fail. This diff makes sure the test is passing. Reviewed By: wushirong Differential Revision: D31153947 fbshipit-source-id: b2a299274e5c440cd52342087cfcdb0b387cc4fb
334787b to
e5d9c0e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31153947 |
Summary: Pull Request resolved: pytorch#5824 After a recent optimization pytorch/pytorch#65014 we started to normalize `aten::rsub` as `aten::sub`, so the test started to fail. This diff makes sure the test is passing. Reviewed By: wushirong Differential Revision: D31153947 fbshipit-source-id: d7034b18c2e44f4ce76481ed68e7ebf94c1bcfa1
e5d9c0e to
eea8606
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31153947 |
|
This pull request has been merged in 2cae846. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: After a recent optimization pytorch/pytorch#65014 we started to normalize
aten::rsubasaten::sub, so the test started to fail. This diff makes sure the test is passing.Reviewed By: wushirong
Differential Revision: D31153947