Add XYZ_INCLUDE_DIR / XYZ_LIB_DIR for CMake dependencies#91
Closed
pietern wants to merge 4 commits intopytorch:masterfrom
Closed
Add XYZ_INCLUDE_DIR / XYZ_LIB_DIR for CMake dependencies#91pietern wants to merge 4 commits intopytorch:masterfrom
pietern wants to merge 4 commits intopytorch:masterfrom
Conversation
This commit also slightly changes the CMake variable naming to remove some cognitive overhead regarding upcase/downcase variables and multiple messages in the CMake output. Input variables are called XYZ_INCLUDE_DIR and XYZ_LIB_DIR, and the internal/output variables are called XYZ_INCLUDE_DIRS and XYZ_LIBRARIES. This looks to be in line with most CMake modules.
Contributor
|
sweet, looks good to me. |
lukeyeager
added a commit
to lukeyeager/caffe2
that referenced
this pull request
Oct 3, 2017
Brings in cmake changes from pytorch/gloo#91
cosmicEarth
pushed a commit
to cosmicEarth/gloo
that referenced
this pull request
Apr 9, 2024
Summary: It is flexible to have both XYZ_INCLUDE_DIR and XYZ_LIB_DIR for each dependency instead of just XYZ_ROOT_DIR. The gloo build should work with whatever directory structure is used for dependencies. This change also slightly changes the CMake variable naming to remove some cognitive overhead regarding upcase/downcase variables and multiple messages in the CMake output. Also see pytorch/pytorch#2877 Closes pytorch/gloo#91 Differential Revision: D5925849 Pulled By: pietern fbshipit-source-id: 66bf7699f736f51e197366c61a9d946bdf1ccec4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is flexible to have both XYZ_INCLUDE_DIR and XYZ_LIB_DIR for each dependency instead of just XYZ_ROOT_DIR. The gloo build should work with whatever directory structure is used for dependencies.
This change also slightly changes the CMake variable naming to remove some cognitive overhead regarding upcase/downcase variables and multiple messages in the CMake output.
Also see pytorch/pytorch#2877