fix anon-struct usage that's a warning/error -Wnon-c-typedef-for-linkage (#137)#328
Open
luciang wants to merge 1 commit intopytorch:mainfrom
Open
fix anon-struct usage that's a warning/error -Wnon-c-typedef-for-linkage (#137)#328luciang wants to merge 1 commit intopytorch:mainfrom
luciang wants to merge 1 commit intopytorch:mainfrom
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D36043476 |
…age (#76610) Summary: X-link: pytorch/pytorch#76610 Pull Request resolved: pytorch#328 X-link: facebookarchive/fbzmq#38 X-link: facebook/CacheLib#137 Fix error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage] Reviewed By: philippv Differential Revision: D36043476 fbshipit-source-id: 6e1dc16bf1d205bfcf1a359f0e812a9bfdb0d039
luciang
added a commit
to luciang/CacheLib
that referenced
this pull request
Apr 30, 2022
…age (#76610) Summary: X-link: pytorch/pytorch#76610 X-link: pytorch/gloo#328 X-link: facebookarchive/fbzmq#38 Pull Request resolved: facebook#137 Fix error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage] Reviewed By: philippv Differential Revision: D36043476 fbshipit-source-id: d26f1bf9952b4371d3d4901ae15a68af8fd4c2a1
a867151 to
7519f32
Compare
|
This pull request was exported from Phabricator. Differential Revision: D36043476 |
luciang
added a commit
to luciang/fbzmq
that referenced
this pull request
Apr 30, 2022
…age (#76610) Summary: X-link: pytorch/pytorch#76610 X-link: pytorch/gloo#328 Pull Request resolved: facebookarchive#38 X-link: facebook/CacheLib#137 Fix error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage] Reviewed By: philippv Differential Revision: D36043476 fbshipit-source-id: 953e43613479fb142ea2ccf29f3d0a39402e4122
luciang
added a commit
to luciang/pytorch
that referenced
this pull request
Apr 30, 2022
…age (pytorch#76610) Summary: Pull Request resolved: pytorch#76610 X-link: pytorch/gloo#328 X-link: facebookarchive/fbzmq#38 X-link: facebook/CacheLib#137 Fix error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage] Test Plan: ```name=before buck-out/v2/gen/fbcode/d839c731f5505c62/datasec/messaging/auth/utils/__MessagingAuthUtils__/headers/datasec/messaging/auth/utils/MessagingAuthLogger.h:83:25: error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage] using LogInfo = struct { ``` CI Reviewed By: philippv Differential Revision: D36043476 fbshipit-source-id: 679f3b5efd0d233f6cb472e9cba54747ffd49c4e
malfet
approved these changes
May 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/CacheLib#137
Fix
error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage]
Reviewed By: philippv
Differential Revision: D36043476