[ExecuTorch] Don't require -march compiler flags to use bfdot#5444
Closed
swolchok wants to merge 3 commits intogh/swolchok/75/basefrom
Closed
[ExecuTorch] Don't require -march compiler flags to use bfdot#5444swolchok wants to merge 3 commits intogh/swolchok/75/basefrom
swolchok wants to merge 3 commits intogh/swolchok/75/basefrom
Conversation
TIL about the `target` clang/GCC function attribute, which allows building a particular function under an `-march` flag instead of a whole file. Differential Revision: [D62905047](https://our.internmc.facebook.com/intern/diff/D62905047/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5444
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b13a7ee with merge base 3512148 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62905047 |
swolchok
added a commit
that referenced
this pull request
Sep 17, 2024
TIL about the `target` clang/GCC function attribute, which allows building a particular function under an `-march` flag instead of a whole file. Differential Revision: [D62905047](https://our.internmc.facebook.com/intern/diff/D62905047/) ghstack-source-id: 243159890 Pull Request resolved: #5444
…dot" TIL about the `target` clang/GCC function attribute, which allows building a particular function under an `-march` flag instead of a whole file. Differential Revision: [D62905047](https://our.internmc.facebook.com/intern/diff/D62905047/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 19, 2024
Pull Request resolved: #5444 TIL about the `target` clang/GCC function attribute, which allows building a particular function under an `-march` flag instead of a whole file. Differential Revision: [D62905047](https://our.internmc.facebook.com/intern/diff/D62905047/) ghstack-source-id: 243534339
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62905047 |
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Sep 19, 2024
ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes not-yet-reviewed pytorch/executorch#5444 . Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Sep 19, 2024
ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes not-yet-reviewed pytorch/executorch#5444 . Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/) ghstack-source-id: 243596406 Pull Request resolved: #136331
malfet
approved these changes
Sep 20, 2024
…dot" TIL about the `target` clang/GCC function attribute, which allows building a particular function under an `-march` flag instead of a whole file. Differential Revision: [D62905047](https://our.internmc.facebook.com/intern/diff/D62905047/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62905047 |
swolchok
added a commit
that referenced
this pull request
Sep 20, 2024
Pull Request resolved: #5444 TIL about the `target` clang/GCC function attribute, which allows building a particular function under an `-march` flag instead of a whole file. ghstack-source-id: 243858419 Differential Revision: [D62905047](https://our.internmc.facebook.com/intern/diff/D62905047/)
Contributor
|
This pull request has been merged in 0eee42a. |
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Sep 23, 2024
…t back to ATen BlasKernel" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes not-yet-reviewed pytorch/executorch#5444 . Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Sep 23, 2024
…lasKernel" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes not-yet-reviewed pytorch/executorch#5444 . Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Sep 23, 2024
…t back to ATen BlasKernel" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes not-yet-reviewed pytorch/executorch#5444 . Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Sep 23, 2024
…lasKernel" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes not-yet-reviewed pytorch/executorch#5444 . Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Sep 23, 2024
Pull Request resolved: #136331 ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes not-yet-reviewed pytorch/executorch#5444 . ghstack-source-id: 244187352 Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/)
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Sep 30, 2024
Pull Request resolved: #136331 ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes pytorch/executorch#5444 . ghstack-source-id: 245455630 Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/)
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Sep 30, 2024
…t back to ATen BlasKernel" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes pytorch/executorch#5444 . Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Sep 30, 2024
…lasKernel" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes pytorch/executorch#5444 . Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Oct 2, 2024
Pull Request resolved: #136331 ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes pytorch/executorch#5444 . ghstack-source-id: 245903000 Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/)
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Oct 2, 2024
…t back to ATen BlasKernel" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes pytorch/executorch#5444 . Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Oct 2, 2024
…lasKernel" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes pytorch/executorch#5444 . Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/) [ghstack-poisoned]
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 3, 2024
…136331) ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. Supersedes #127488 . Includes pytorch/executorch#5444 . Differential Revision: [D63045939](https://our.internmc.facebook.com/intern/diff/D63045939/) Pull Request resolved: #136331 Approved by: https://github.com/malfet, https://github.com/albanD ghstack dependencies: #136445
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
TIL about the
targetclang/GCC function attribute, which allows building a particular function under an-marchflag instead of a whole file.Differential Revision: D62905047