Update fused kernels and call _safe_softmax from SDPA by drisspg · Pull Request #4772 · pytorch/executorch

drisspg · 2024-08-17T05:33:24Z

Summary:
X-link: pytorch/pytorch#131863

cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233

imported-using-ghimport

Reviewed By: Chillee

Differential Revision: D61418679

Pulled By: drisspg

pytorch-bot · 2024-08-17T05:33:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4772

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (30 Unrelated Failures)

As of commit 388a062 with merge base 6cb5726 ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

Apple / build-frameworks-ios / macos-job (gh) (similar failure)
Apple / test-demo-ios / macos-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-binary-size-linux / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-binary-size-linux-gcc / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-custom-ops-linux (buck2) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-custom-ops-linux (cmake) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-export-llava-linux / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-llama-runner-linux (fp32, buck2, portable) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-llama-runner-linux (fp32, buck2, xnnpack+custom) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-llama-runner-linux (fp32, buck2, xnnpack+custom+qe) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-llama-runner-linux (fp32, cmake, portable) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-llama-runner-linux (fp32, cmake, xnnpack+custom) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-llama-runner-linux (fp32, cmake, xnnpack+custom+qe) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-llama-runner-linux-android (cmake) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-llama-runner-qnn-linux (fp32, cmake, qnn) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux (buck2, mv3, portable, linux.2xlarge, 90) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux (buck2, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux (cmake, mv3, portable, linux.2xlarge, 90) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux (cmake, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux (cmake, vit, portable, linux.2xlarge, 90) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux (cmake, vit, xnnpack-delegation, linux.2xlarge, 90) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-pybind-build-linux (cmake) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-quantized-aot-lib-linux (cmake) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-selective-build-linux (buck2) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-selective-build-linux (cmake) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-setup-linux-gcc (cmake) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / unittest / linux / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / unittest / macos / macos-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / unittest-arm (buck2) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

Build documentation / build (buck2) / Build doc (gh) (trunk failure)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-08-17T05:33:46Z

This pull request was exported from Phabricator. Differential Revision: D61418679

facebook-github-bot · 2024-08-17T16:59:11Z

This pull request was exported from Phabricator. Differential Revision: D61418679

Summary: Pull Request resolved: pytorch#4772 X-link: pytorch/pytorch#131863 cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233 imported-using-ghimport Test Plan: Imported from OSS Reviewed By: Chillee Differential Revision: D61418679 Pulled By: drisspg

facebook-github-bot · 2024-08-17T17:07:04Z

This pull request was exported from Phabricator. Differential Revision: D61418679

Summary: Pull Request resolved: pytorch#4772 X-link: pytorch/pytorch#131863 cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233 imported-using-ghimport Test Plan: Imported from OSS Reviewed By: Chillee Differential Revision: D61418679 Pulled By: drisspg

facebook-github-bot · 2024-08-17T17:46:33Z

This pull request was exported from Phabricator. Differential Revision: D61418679

Summary: Pull Request resolved: pytorch#4772 X-link: pytorch/pytorch#131863 cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233 imported-using-ghimport Test Plan: Imported from OSS Reviewed By: Chillee Differential Revision: D61418679 Pulled By: drisspg

shoumikhin · 2024-08-17T19:13:49Z

@YifanShenSZ ptal when you have a chance!

backends/apple/coreml/test/test_coreml_partitioner.py

Summary: Pull Request resolved: pytorch#4772 X-link: pytorch/pytorch#131863 cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233 imported-using-ghimport Test Plan: Imported from OSS Reviewed By: Chillee Differential Revision: D61418679 Pulled By: drisspg

facebook-github-bot · 2024-08-19T00:33:48Z

This pull request was exported from Phabricator. Differential Revision: D61418679

YifanShenSZ

Awesome safe softmax 🎊 & thanks for the subsequent fix in executorch 🙏

drisspg · 2024-08-19T01:54:08Z

@shoumikhin not totally sure what to do about how red executorch trunk is on this one

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 17, 2024

facebook-github-bot added the fb-exported label Aug 17, 2024

drisspg force-pushed the export-D61418679 branch from 699f6bb to 27a4a02 Compare August 17, 2024 16:59

drisspg force-pushed the export-D61418679 branch from 27a4a02 to 3a49525 Compare August 17, 2024 17:07

drisspg force-pushed the export-D61418679 branch from 3a49525 to 30eef3d Compare August 17, 2024 17:46

YifanShenSZ reviewed Aug 17, 2024

View reviewed changes

backends/apple/coreml/test/test_coreml_partitioner.py Show resolved Hide resolved

drisspg force-pushed the export-D61418679 branch from 30eef3d to 388a062 Compare August 19, 2024 00:33

YifanShenSZ approved these changes Aug 19, 2024

View reviewed changes

shoumikhin approved these changes Aug 19, 2024

View reviewed changes

facebook-github-bot merged commit 9e478e8 into pytorch:main Aug 19, 2024

YifanShenSZ mentioned this pull request Oct 18, 2024

[Core ML] Update Partitioner Test as Torch.Any Supported #6361

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update fused kernels and call _safe_softmax from SDPA#4772

Update fused kernels and call _safe_softmax from SDPA#4772
facebook-github-bot merged 1 commit intopytorch:mainfrom
drisspg:export-D61418679

drisspg commented Aug 17, 2024

Uh oh!

pytorch-bot bot commented Aug 17, 2024 •

edited

Loading

Uh oh!

facebook-github-bot commented Aug 17, 2024

Uh oh!

facebook-github-bot commented Aug 17, 2024

Uh oh!

facebook-github-bot commented Aug 17, 2024

Uh oh!

facebook-github-bot commented Aug 17, 2024

Uh oh!

shoumikhin commented Aug 17, 2024

Uh oh!

Uh oh!

facebook-github-bot commented Aug 19, 2024

Uh oh!

YifanShenSZ left a comment

Uh oh!

drisspg commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

drisspg commented Aug 17, 2024

Uh oh!

pytorch-bot bot commented Aug 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4772

✅ You can merge normally! (30 Unrelated Failures)

Uh oh!

facebook-github-bot commented Aug 17, 2024

Uh oh!

facebook-github-bot commented Aug 17, 2024

Uh oh!

facebook-github-bot commented Aug 17, 2024

Uh oh!

facebook-github-bot commented Aug 17, 2024

Uh oh!

shoumikhin commented Aug 17, 2024

Uh oh!

Uh oh!

facebook-github-bot commented Aug 19, 2024

Uh oh!

YifanShenSZ left a comment

Choose a reason for hiding this comment

Uh oh!

drisspg commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pytorch-bot bot commented Aug 17, 2024 •

edited

Loading