Enable is_causal tests for sdpa with kv cache op#4066
Closed
kimishpatel wants to merge 4 commits intogh/kimishpatel/57/basefrom
Closed
Enable is_causal tests for sdpa with kv cache op#4066kimishpatel wants to merge 4 commits intogh/kimishpatel/57/basefrom
kimishpatel wants to merge 4 commits intogh/kimishpatel/57/basefrom
Conversation
THis required changing attention calculation to account for start pos. Look at the code for detailed comments and future TODO. Differential Revision: [D58874165](https://our.internmc.facebook.com/intern/diff/D58874165/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4066
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d52d4ea with merge base 38046ba ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58874165 |
This was referenced Jun 25, 2024
larryliu0820
approved these changes
Jun 26, 2024
THis required changing attention calculation to account for start pos. Look at the code for detailed comments and future TODO. Differential Revision: [D58874165](https://our.internmc.facebook.com/intern/diff/D58874165/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58874165 |
THis required changing attention calculation to account for start pos. Look at the code for detailed comments and future TODO. Differential Revision: [D58874165](https://our.internmc.facebook.com/intern/diff/D58874165/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58874165 |
THis required changing attention calculation to account for start pos. Look at the code for detailed comments and future TODO. Differential Revision: [D58874165](https://our.internmc.facebook.com/intern/diff/D58874165/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58874165 |
Contributor
|
This pull request has been merged in 51c3210. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#4066 THis required changing attention calculation to account for start pos. Look at the code for detailed comments and future TODO. //unrelated failures @bypass-github-export-checks ghstack-source-id: 231807012 @exported-using-ghexport Differential Revision: [D58874165](https://our.internmc.facebook.com/intern/diff/D58874165/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
THis required changing attention calculation to account for start pos.
Look at the code for detailed comments and future TODO.
Differential Revision: D58874165