Preparatory fixes & lint suppressions for c10::optional->std::optional#1226
Closed
swolchok wants to merge 1 commit intopytorch:mainfrom
Closed
Preparatory fixes & lint suppressions for c10::optional->std::optional#1226swolchok wants to merge 1 commit intopytorch:mainfrom
swolchok wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1226
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 543a539 with merge base 6dc3391 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51355841 |
Contributor
|
XNNPACK errors seems unrelated to me. |
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
Nov 16, 2023
pytorch#1226) Summary: X-link: pytorch/FBGEMM#2138 Landing non-PyTorch portions first; then the PyTorch portions of pytorch/pytorch#101995 will land to Github. Reviewed By: malfet Differential Revision: D51355841
70edb7a to
aeb2729
Compare
swolchok
added a commit
to swolchok/FBGEMM
that referenced
this pull request
Nov 16, 2023
pytorch#2138) Summary: X-link: pytorch/executorch#1226 Landing non-PyTorch portions first; then the PyTorch portions of pytorch/pytorch#101995 will land to Github. Reviewed By: malfet Differential Revision: D51355841
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51355841 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51355841 |
pytorch#1226) Summary: X-link: pytorch/FBGEMM#2138 Landing non-PyTorch portions first; then the PyTorch portions of pytorch/pytorch#101995 will land to Github. Reviewed By: malfet Differential Revision: D51355841
swolchok
added a commit
to swolchok/FBGEMM
that referenced
this pull request
Nov 27, 2023
pytorch#2138) Summary: X-link: pytorch/executorch#1226 Landing non-PyTorch portions first; then the PyTorch portions of pytorch/pytorch#101995 will land to Github. Reviewed By: malfet Differential Revision: D51355841
aeb2729 to
e3b933f
Compare
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
Nov 27, 2023
pytorch#1226) Summary: X-link: pytorch/FBGEMM#2138 Landing non-PyTorch portions first; then the PyTorch portions of pytorch/pytorch#101995 will land to Github. Reviewed By: malfet Differential Revision: D51355841
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51355841 |
swolchok
added a commit
to swolchok/FBGEMM
that referenced
this pull request
Nov 27, 2023
pytorch#2138) Summary: X-link: pytorch/executorch#1226 Landing non-PyTorch portions first; then the PyTorch portions of pytorch/pytorch#101995 will land to Github. Reviewed By: malfet Differential Revision: D51355841
e3b933f to
543a539
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51355841 |
Contributor
|
This pull request has been merged in 61aad49. |
facebook-github-bot
pushed a commit
to pytorch/FBGEMM
that referenced
this pull request
Nov 28, 2023
#2138) Summary: X-link: pytorch/executorch#1226 Pull Request resolved: #2138 Landing non-PyTorch portions first; then the PyTorch portions of pytorch/pytorch#101995 will land to Github. Reviewed By: malfet Differential Revision: D51355841 fbshipit-source-id: 4eed885733189f21e342613431b637de72979cb4
liligwu
pushed a commit
to ROCm/FBGEMM
that referenced
this pull request
Feb 16, 2024
pytorch#2138) Summary: X-link: pytorch/executorch#1226 Pull Request resolved: pytorch#2138 Landing non-PyTorch portions first; then the PyTorch portions of pytorch/pytorch#101995 will land to Github. Reviewed By: malfet Differential Revision: D51355841 fbshipit-source-id: 4eed885733189f21e342613431b637de72979cb4
pytorch-bot bot
pushed a commit
to pytorch/FBGEMM
that referenced
this pull request
Feb 26, 2026
#2138) Summary: X-link: pytorch/executorch#1226 Pull Request resolved: #2138 Landing non-PyTorch portions first; then the PyTorch portions of pytorch/pytorch#101995 will land to Github. Reviewed By: malfet Differential Revision: D51355841 fbshipit-source-id: 4eed885733189f21e342613431b637de72979cb4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Landing non-PyTorch portions first; then the PyTorch portions of pytorch/pytorch#101995 will land to Github.
Reviewed By: malfet
Differential Revision: D51355841