Fixes the cpuinfo_get_max_arm_sve_length API bug on NON-SVE supported hardware.#258
Conversation
*The current API - cpuinfo_get_max_arm_sve_length() when integarted into PyTorch and tested on Graviton2 (NON SVE hardware), it fails with an error. Signed-off-by: maajidkhann <maajidkhan.n@fujitsu.com>
|
@malfet Please review and merge this small change. |
|
cpuinfo_log_error() does not terminate the execution. Can you please tell how replacing cpuinfo_log_error() with cpuinfo_log_waring() fixes the graviton2 test failure? |
I made this change in cpuinfo and called the API from PyTorch on Graviton 2. I don't see it terminating the execution now like earlier. cpuinfo_log_warning() doesn't terminate the execution, it just a warning. You can also see same is being used multiple times in the same file. |
|
cc: @fbarchard @digantdesai |
|
I don't think |
Yes the cpuinfo needs to be updated in PyTorch to reflect the changes in PyTorch PR CI: @digantdesai Will you be able to update it? |
Spiritual cherry-pick of #138351 that picks pytorch/cpuinfo#258 into the branch
Spiritual cherry-pick of #138351 that picks pytorch/cpuinfo#258 into the branch Fixes #138333 Test Plan: `python -c "import torch"` finishes without any output on the screen
The current API - cpuinfo_get_max_arm_sve_length() when integrated into PyTorch works well on SVE supported hardware but when tested on Graviton2 (NON SVE hardware), it fails with the below error.
This PR fixes this bug on Non SVE supported hardware:
Changes:
cpuinfo_log_error (wrong change) -> cpuinfo_log_warning (Right change)