Skip to content

Delete deprecated PackedLinearInt8DynamicActivationIntxWeightLayout and related code#4150

Merged
jerryzh168 merged 27 commits into
mainfrom
gh/jerryzh168/66/head
Mar 24, 2026
Merged

Delete deprecated PackedLinearInt8DynamicActivationIntxWeightLayout and related code#4150
jerryzh168 merged 27 commits into
mainfrom
gh/jerryzh168/66/head

Conversation

@pytorch-bot

pytorch-bot Bot commented Mar 23, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4150

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 10 Pending

As of commit 04f0ca4 with merge base 1b2682d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…ctivationIntxWeightLayout and related code"

[ghstack-poisoned]
…ghtLayout and related code"

[ghstack-poisoned]
…ctivationIntxWeightLayout and related code"

[ghstack-poisoned]
…ghtLayout and related code"

[ghstack-poisoned]
…ctivationIntxWeightLayout and related code"

[ghstack-poisoned]
…ghtLayout and related code"

[ghstack-poisoned]
@jerryzh168 jerryzh168 added the module: not user facing Use this tag if you don't want this PR to show up in release notes label Mar 23, 2026
…ctivationIntxWeightLayout and related code"

[ghstack-poisoned]
…ghtLayout and related code"

[ghstack-poisoned]
…ctivationIntxWeightLayout and related code"

[ghstack-poisoned]
…ghtLayout and related code"

[ghstack-poisoned]
@jerryzh168

Copy link
Copy Markdown
Contributor Author

@claude review

@claude

claude Bot commented Mar 24, 2026

Copy link
Copy Markdown

Claude finished @jerryzh168's task in 1m 27s —— View job


Code Review: Delete deprecated PackedLinearInt8DynamicActivationIntxWeightLayout

  • Review the diff and understand changes
  • Check for remaining references to deleted code
  • Provide review feedback

This is a clean deletion PR. The changes are straightforward and correct.

What's being removed:

  1. The entire packed_linear_int8_dynamic_activation_intx_weight_layout.py file (474 lines) — including the PackedLinearInt8DynamicActivationIntxWeightLayout class, its AQTTensorImpl subclass, linear dispatch check/impl functions, and the Target enum
  2. Imports and dispatch registrations in affine_quantized_tensor_ops.py
  3. Re-exports in torchao/dtypes/__init__.py and torchao/dtypes/uintx/__init__.py
  4. Target import and safe-global registration in quant_api.py

Verification:

  • No remaining references to PackedLinearInt8DynamicActivationIntxWeight* anywhere in the codebase
  • No remaining references to _linear_int8_act_intx_weight_packed_* functions
  • No remaining references to make_packed_linear_int8_dynamic_activation_intx_weight_tensor
  • The Target enum is fully removed (no remaining uses in quant_api.py)
  • The deleted code already had deprecation warnings pointing to issues #2752 and #2967

Minor note: The __all__ in torchao/dtypes/__init__.py previously included two stale entries — to_affine_quantized_packed_linear_int8_dynamic_activation_intx_weight and Int4GroupwisePreshuffleTensor — that were never actually imported. This PR correctly removes them as well.

LGTM — no issues found.

…ctivationIntxWeightLayout and related code"

[ghstack-poisoned]
…ghtLayout and related code"

[ghstack-poisoned]
…ctivationIntxWeightLayout and related code"

[ghstack-poisoned]
…ghtLayout and related code"

[ghstack-poisoned]
…ctivationIntxWeightLayout and related code"

[ghstack-poisoned]
…ghtLayout and related code"

[ghstack-poisoned]
…ctivationIntxWeightLayout and related code"

[ghstack-poisoned]
…ghtLayout and related code"

[ghstack-poisoned]
@jerryzh168 jerryzh168 changed the base branch from gh/jerryzh168/66/base to main March 24, 2026 21:07
@jerryzh168 jerryzh168 merged commit 1f90b4d into main Mar 24, 2026
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants