Remove Int8DynamicActivationInt4WeightConfig#3884
Merged
jcaip merged 2 commits intogh/jcaip/3/basefrom Feb 19, 2026
Merged
Conversation
This config was deprecated in favor of Int8DynamicActivationIntxWeightConfig. Remove the class definition, handler, and all references from imports, tests, QAT code, benchmarks, and documentation. Update QAT docs to reference Int4WeightOnlyConfig as the example base config. Co-authored-by: Cursor <cursoragent@cursor.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3884
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 5 Unrelated FailuresAs of commit cde821b with merge base d4c1ba3 ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 13, 2026
jerryzh168
reviewed
Feb 13, 2026
| .. code:: py | ||
|
|
||
| from torchao.quantization import quantize_, Int8DynamicActivationInt4WeightConfig | ||
| from torchao.quantization import quantize_, Int4WeightOnlyConfig |
Contributor
There was a problem hiding this comment.
replacement for this config is Int8DynamicActivationIntxWeightConfig I think, maybe change to that?
jerryzh168
reviewed
Feb 13, 2026
|
|
||
| if __name__ == "__main__": | ||
| run_tests() | ||
| # Tests removed: Int8DynamicActivationInt4WeightConfig has been removed. |
Contributor
There was a problem hiding this comment.
just remove the file?
also cc @Xia-Weiwen we are using Int8DynamicActivationIntxWeightConfig to replace Int8DynamicActivationInt4WeightConfig now, in case you want to keep the CPU version of this config
Collaborator
There was a problem hiding this comment.
Oh, Thanks @jerryzh168 I missed this message. And the DA8W4 workflow is broken on CPU now. I will work on a PR to fix the workflow and add these test cases back.
Contributor
|
Remember to import this. There were a lot of internal use cases! |
17 tasks
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This config was deprecated in favor of Int8DynamicActivationIntxWeightConfig.
Remove the class definition, handler, and all references from imports, tests,
QAT code, benchmarks, and documentation. Update QAT docs to reference
Int4WeightOnlyConfig as the example base config.
Co-authored-by: Cursor cursoragent@cursor.com