Float8StaticActivationFloat8WeightConfig using keepdim=True#3759
Merged
Conversation
Summary: - Pass keepdim=True to all AffineQuantizedMinMaxObserver instances in Float8StaticActivationFloat8WeightConfig transform to preserve scale tensor dimensions - Remove manual scale reshaping workarounds after calculate_qparams() calls since keepdim=True now handles this - Extend test_static_quant_with_output_quantization with parametrize to test both 2D and 3D inputs Test Plan: - Run test_static_quant_with_output_quantization with both input shapes: - 2D: (4, 64) - 3D: (2, 4, 64) - Verify existing float8 static quantization tests still pass Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3759
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3176409 with merge base c6c34d4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jerryzh168
added a commit
that referenced
this pull request
Jan 29, 2026
Summary: - Pass keepdim=True to all AffineQuantizedMinMaxObserver instances in Float8StaticActivationFloat8WeightConfig transform to preserve scale tensor dimensions - Remove manual scale reshaping workarounds after calculate_qparams() calls since keepdim=True now handles this - Extend test_static_quant_with_output_quantization with parametrize to test both 2D and 3D inputs Test Plan: - Run test_static_quant_with_output_quantization with both input shapes: - 2D: (4, 64) - 3D: (2, 4, 64) - Verify existing float8 static quantization tests still pass Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9b69d32 Pull Request resolved: #3759
howardzhang-cv
approved these changes
Jan 29, 2026
andrewor14
added a commit
that referenced
this pull request
Jan 29, 2026
**Summary:** ``` pytest test/test_ops_rowwise_scaled_linear_sparse_cutlass.py ``` This gives ``` E RuntimeError: The size of tensor a (4) must match the size of tensor b (65) at non-singleton dimension 1 ``` Seems like it's caused by #3759. We just need to update the test. **Test Plan:** ``` pytest test/test_ops_rowwise_scaled_linear_sparse_cutlass.py ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: