Skip to content

Deleted activation24, fp8 gemm with 2:4 sparsity#3726

Merged
andrewor14 merged 2 commits into
gh/howardzhang-cv/7/basefrom
gh/howardzhang-cv/7/head
Jan 28, 2026
Merged

Deleted activation24, fp8 gemm with 2:4 sparsity#3726
andrewor14 merged 2 commits into
gh/howardzhang-cv/7/basefrom
gh/howardzhang-cv/7/head

Conversation

@howardzhang-cv

@howardzhang-cv howardzhang-cv commented Jan 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Summary: Deleted torchao/csrc/cuda/activation24
Included sparsify24.cu and sparse_gemm.cu
Deleted SRELU that depended on the above kernels
Deleted associated ops, references, and tests

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D91519835

@howardzhang-cv
Update
efbf341 
[ghstack-poisoned]
howardzhang-cv added a commit that referenced this pull request Jan 26, 2026
@howardzhang-cv
Deleted activation24, fp8 gemm with 2:4 sparsity
35f05c5 
Summary: Deleted torchao/csrc/cuda/activation24
Included sparsify24.cu and sparse_gemm.cu
Deleted SRELU that depended on the above kernels
Deleted associated ops, references, and tests

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 93875d6
Pull-Request: #3726
@pytorch-bot

pytorch-bot Bot commented Jan 26, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3726

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 544fa8e with merge base 4ce55c3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 26, 2026
@howardzhang-cv

howardzhang-cv commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

@howardzhang-cv has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@howardzhang-cv howardzhang-cv added module: bc-breaking Use this tag if this PR breaks backward compatibility module: deprecation Use this tag if this PR deprecates a feature labels Jan 26, 2026
@howardzhang-cv howardzhang-cv mentioned this pull request Jan 27, 2026
Closed
@howardzhang-cv
Update
544fa8e 
[ghstack-poisoned]
howardzhang-cv added a commit that referenced this pull request Jan 27, 2026
@howardzhang-cv
Deleted activation24, fp8 gemm with 2:4 sparsity
cd9f414 
Summary: Deleted torchao/csrc/cuda/activation24
Included sparsify24.cu and sparse_gemm.cu
Deleted SRELU that depended on the above kernels
Deleted associated ops, references, and tests

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: d1537fa
Pull-Request: #3726
@howardzhang-cv

howardzhang-cv commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

@howardzhang-cv has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jerryzh168

jerryzh168 commented Jan 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

there is no quant API related to these ops? oh sorry, just saw that, it's SRELUFloat8SemiSparseDynamicActivationFloat8WeightConfig

@howardzhang-cv

howardzhang-cv commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

The diff seems to not have any internal failures, but we should probably wait for a response from the ads team before deleting this? @jerryzh168 @andrewor14 should I land or wait for a response first?

@jerryzh168

jerryzh168 commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

The diff seems to not have any internal failures, but we should probably wait for a response from the ads team before deleting this? @jerryzh168 @andrewor14 should I land or wait for a response first?

yeah probably safer to wait for a response

@andrewor14

andrewor14 commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Thanks, seems like there are no internal users. Merging this

@andrewor14 andrewor14 merged commit 1ed8301 into gh/howardzhang-cv/7/base Jan 28, 2026
55 of 56 checks passed
@andrewor14

andrewor14 commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Ah shoot I merged it into the wrong branch. @howardzhang-cv do you mind creating a new PR with the exact same changes? Sorry

howardzhang-cv added a commit that referenced this pull request Jan 28, 2026
@howardzhang-cv
Deleted activation24, fp8 gemm with 2:4 sparsity
2695b13 
Summary: Deleted torchao/csrc/cuda/activation24
Included sparsify24.cu and sparse_gemm.cu
Deleted SRELU that depended on the above kernels
Deleted associated ops, references, and tests

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: d1537fa
Pull-Request: #3726
@howardzhang-cv howardzhang-cv mentioned this pull request Jan 28, 2026
Merged
howardzhang-cv added a commit that referenced this pull request Jan 28, 2026
@howardzhang-cv
Deleted activation24, fp8 gemm with 2:4 sparsity (#3744)
a003c32 
Summary: Deleted torchao/csrc/cuda/activation24
Included sparsify24.cu and sparse_gemm.cu
Deleted SRELU that depended on the above kernels
Deleted associated ops, references, and tests

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: d1537fa
Pull-Request: #3726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewor14 andrewor14 andrewor14 approved these changes

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: bc-breaking Use this tag if this PR breaks backward compatibility module: deprecation Use this tag if this PR deprecates a feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@howardzhang-cv @jerryzh168 @andrewor14