3/x mx cleanup: speed up local test suite#3383
Merged
Merged
Conversation
Contributor
Author
vkuzo
added a commit
that referenced
this pull request
Nov 24, 2025
Summary: * Before, worst case: ~4 minutes * Before, best case: ~2 minutes * After: ~82 sec Changes: 1. test smaller shapes in triton kernel tests, sometimes the large shapes are expensive in local runs 2. remove testing of mxfp4 + compile, it's really slow and not useful yet Test Plan: ``` pytest test/prototype/mx_formats/ -s ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9e8313a ghstack-comment-id: 3571962428 Pull-Request: #3383
This was referenced Nov 24, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3383
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| "scale_calculation_mode", | ||
| [ | ||
| ScaleCalculationMode.FLOOR, | ||
| ScaleCalculationMode.CEIL, |
Contributor
There was a problem hiding this comment.
is this removed because in practice we're only using floor and rceil?
Contributor
Author
There was a problem hiding this comment.
yep!
CEIL is still tested for eager, this removes it from compile
danielvegamyhre
approved these changes
Nov 24, 2025
This was referenced Nov 24, 2025
jerryzh168
approved these changes
Nov 24, 2025
namgyu-youn
pushed a commit
to namgyu-youn/ao
that referenced
this pull request
Dec 19, 2025
* Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changes:
shapes are expensive in local runs
yet
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: