Makes fallback float8 1x128 by 128x128 gemm output bfloat16#3265
Merged
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3265
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit c877d67 with merge base f856d36 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Oct 30, 2025
Summary: For now, we just care about bf16 output. We can add fp32 and a flag to control it later, if needed. Test Plan: ``` pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: b3c443c ghstack-comment-id: 3469836810 Pull-Request: #3265
This was referenced Oct 30, 2025
vkuzo
added a commit
that referenced
this pull request
Oct 31, 2025
Summary: For now, we just care about bf16 output. We can add fp32 and a flag to control it later, if needed. Test Plan: ``` pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f00cd47 ghstack-comment-id: 3469836810 Pull-Request: #3265
vkuzo
added a commit
that referenced
this pull request
Oct 31, 2025
Summary: For now, we just care about bf16 output. We can add fp32 and a flag to control it later, if needed. Test Plan: ``` pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -k fp8_linear_variants -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 8a63a04 ghstack-comment-id: 3469836810 Pull-Request: #3265
danielvegamyhre
approved these changes
Oct 31, 2025
danielvegamyhre
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Btw in my benchmarks I found the torch._scaled_mm cutlass kernel for blockwise gemms to be much faster than the triton kernels. This was a few months ago, you can run the benchmarks scripts in this dir if you want: https://github.com/pytorch/ao/tree/main/benchmarks/prototype/blockwise_fp8_training
Contributor
Author
Yes, two things for ^:
|
namgyu-youn
pushed a commit
to namgyu-youn/ao
that referenced
this pull request
Nov 21, 2025
…3265) * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
For now, we just care about bf16 output. We can add fp32 and a flag to
control it later, if needed.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: