Support int8 output for scaled_embedding_bag#3231
Merged
Xia-Weiwen merged 13 commits intoNov 6, 2025
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3231
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit d168675 with merge base 7d91f11 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot label "topic: new feature" |
Contributor
Author
|
@Xia-Weiwen @mingfeima Could you help review this PR? |
Xia-Weiwen
reviewed
Oct 24, 2025
Xia-Weiwen
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Some minor changes are needed.
Collaborator
|
CC @mingfeima for review. Thanks. |
Co-authored-by: Xia Weiwen <xia.weiwen@hotmail.com>
Co-authored-by: Xia Weiwen <xia.weiwen@hotmail.com>
Xia-Weiwen
approved these changes
Oct 27, 2025
mingfeima
approved these changes
Oct 28, 2025
Contributor
Author
|
@jerryzh168 Could you help review this pr? |
Contributor
Author
|
@jerryzh168 Could you help review this pr? |
jerryzh168
approved these changes
Nov 6, 2025
namgyu-youn
pushed a commit
to namgyu-youn/ao
that referenced
this pull request
Nov 21, 2025
* re-enable scaled_embedding_bag * only support fp32 out_dtype * support int8 output * support int8 fallback path * fix lint * fix lint and clang * refine scale Co-authored-by: Xia Weiwen <xia.weiwen@hotmail.com> * refine code Co-authored-by: Xia Weiwen <xia.weiwen@hotmail.com> * refine code --------- Co-authored-by: Xia Weiwen <xia.weiwen@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.