Skip to content

Remove old TORCH_VERSION variables#3146

Merged
andrewor14 merged 13 commits into
mainfrom
gh/andrewor14/28/head
Nov 10, 2025
Merged

Remove old TORCH_VERSION variables#3146
andrewor14 merged 13 commits into
mainfrom
gh/andrewor14/28/head

Conversation

@andrewor14

@andrewor14 andrewor14 commented Oct 10, 2025

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Summary: As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

Test Plan: CI

**Summary:** As a follow-up to #2994,
this commit removes all quantization functions that were used
as configs. These functions were deprecated in 0.14.0 and will
be removed in the next release, 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Oct 10, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3146

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 41d0bfb with merge base 6259e98 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2025
@andrewor14 andrewor14 added the module: bc-breaking Use this tag if this PR breaks backward compatibility label Oct 10, 2025
andrewor14 added a commit that referenced this pull request Oct 13, 2025
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

ghstack-source-id: 7c81628
Pull Request resolved: #3146
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
@andrewor14 andrewor14 changed the base branch from gh/andrewor14/28/base to main October 13, 2025 17:44
andrewor14 added a commit that referenced this pull request Oct 13, 2025
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

ghstack-source-id: 7d1f063
Pull Request resolved: #3146
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
@meta-codesync

meta-codesync Bot commented Nov 7, 2025

Copy link
Copy Markdown

@andrewor14 has imported this pull request. If you are a Meta employee, you can view this in D86528619.

**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
andrewor14 added a commit to andrewor14/torchtune that referenced this pull request Nov 7, 2025
andrewor14 added a commit to andrewor14/torchtune that referenced this pull request Nov 7, 2025
@andrewor14

andrewor14 commented Nov 7, 2025

Copy link
Copy Markdown
Contributor Author

@andrewor14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

THIS IS WRONG, the real diff is https://www.internalfb.com/diff/D86528619

@andrewor14 andrewor14 merged commit e8c4d09 into main Nov 10, 2025
36 of 37 checks passed
jainapurva pushed a commit that referenced this pull request Nov 13, 2025
* Remove config functions like `int4_weight_only`

**Summary:** As a follow-up to #2994,
this commit removes all quantization functions that were used
as configs. These functions were deprecated in 0.14.0 and will
be removed in the next release, 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]

* Remove old TORCH_VERSION variables

**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]

* Update base for Update on "Remove old TORCH_VERSION variables"


**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]

* Update base for Update on "Remove old TORCH_VERSION variables"


**Summary:** As a follow-up to #2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
andrewor14 added a commit to andrewor14/torchtune that referenced this pull request Nov 20, 2025
)

Summary:
Specifically, this unblocks:
pytorch/ao#3308
pytorch/ao#3146


Reviewed By: ebsmothers

Differential Revision: D86531665

Pulled By: andrewor14
namgyu-youn pushed a commit to namgyu-youn/ao that referenced this pull request Nov 21, 2025
* Remove config functions like `int4_weight_only`

**Summary:** As a follow-up to pytorch#2994,
this commit removes all quantization functions that were used
as configs. These functions were deprecated in 0.14.0 and will
be removed in the next release, 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]

* Remove old TORCH_VERSION variables

**Summary:** As a follow-up to pytorch#2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]

* Update base for Update on "Remove old TORCH_VERSION variables"


**Summary:** As a follow-up to pytorch#2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]

* Update base for Update on "Remove old TORCH_VERSION variables"


**Summary:** As a follow-up to pytorch#2719,
which deprecated these variables in 0.13.0, we remove them now in
the next release 0.15.0.

**Test Plan:** CI

[ghstack-poisoned]
andrewor14 added a commit to andrewor14/torchtune that referenced this pull request Dec 5, 2025
)

Summary:
Specifically, this unblocks:
pytorch/ao#3308
pytorch/ao#3146


Reviewed By: ebsmothers

Differential Revision: D86531665

Pulled By: andrewor14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: bc-breaking Use this tag if this PR breaks backward compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants