mxtensor: support clone#3070
Merged
Merged
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3070
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 26, 2025
This was referenced Sep 26, 2025
| memory_format = kwargs.get("memory_format", None) | ||
|
|
||
| if memory_format is not None: | ||
| clone_fn = lambda x: x.clone(memory_format=memory_format) |
Contributor
There was a problem hiding this comment.
Why not just avoid the if statement with clone_fn = lambda x: x.clone(**kwargs)? Do we need to explicitly exclude other kwargs and only include memory format if specified, for some reason?
Contributor
Author
There was a problem hiding this comment.
this is copy-pasta from
, IMO let's separate cleanup of this into a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is needed for saving HF models with mxfp4 weights to disk.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: