Remove group_size arg in Float8DynamicActivationInt4WeightConfig#2779
Merged
Conversation
Summary: Fixes: pytorch#2763 Test Plan: python test/quantization/quantize_/workflows/int4/test_int4_preshuffled_tensor.py Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2779
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5013a27 with merge base 9e3758d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
andrewor14
approved these changes
Aug 18, 2025
andrewor14
added a commit
that referenced
this pull request
Aug 22, 2025
**Summary:** After #2779, `Float8DynamicActivationInt4Weight` no longer has the `group_size` field, but QAT continues to read from this field. This commit fixes it to just use the fixed 128 group size. **Test Plan:** ``` python test/quantization/test_qat.py -k test_infer_fp8_int4_config ```
Merged
andrewor14
added a commit
that referenced
this pull request
Aug 22, 2025
**Summary:** After #2779, `Float8DynamicActivationInt4Weight` no longer has the `group_size` field, but QAT continues to read from this field. This commit fixes it to just use the fixed 128 group size. **Test Plan:** ``` python test/quantization/test_qat.py -k test_infer_fp8_int4_config ```
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
Summary: Fixes: #2763 Test Plan: python test/quantization/quantize_/workflows/int4/test_int4_preshuffled_tensor.py Reviewers: Subscribers: Tasks: Tags:
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
**Summary:** After #2779, `Float8DynamicActivationInt4Weight` no longer has the `group_size` field, but QAT continues to read from this field. This commit fixes it to just use the fixed 128 group size. **Test Plan:** ``` python test/quantization/test_qat.py -k test_infer_fp8_int4_config ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes: #2763
Test Plan:
python test/quantization/quantize_/workflows/int4/test_int4_preshuffled_tensor.py
Reviewers:
Subscribers:
Tasks:
Tags: