enable powers of 2 cast in float8 rowwise_with_gw_hp recipe#2677
Merged
Conversation
Summary: This should have been enabled from the time we added the powers of 2 scaling, fixing. Test Plan: ``` with-proxy CONFIG_FILE="./torchtitan/models/llama3/train_configs/llama3_8b.toml" ./run_train.sh --model.print_after_conversion --model.converters float8 --training.compile --float8.recipe_name rowwise_with_gw_hp ``` Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2677
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New FailuresAs of commit 9c72c1b with merge base 7dbc816 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
andrewor14
approved these changes
Aug 6, 2025
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
Summary: This should have been enabled from the time we added the powers of 2 scaling, fixing. Test Plan: ``` with-proxy CONFIG_FILE="./torchtitan/models/llama3/train_configs/llama3_8b.toml" ./run_train.sh --model.print_after_conversion --model.converters float8 --training.compile --float8.recipe_name rowwise_with_gw_hp ``` Reviewers: Subscribers: Tasks: Tags:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This should have been enabled from the time we added the powers of 2 scaling, fixing.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: