simplify Float8Linear#2594
Merged
Merged
Conversation
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2594
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1c1ad9c with merge base 12ff479 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Jul 24, 2025
Summary: Removing code which we no longer need after #2356 . `torch.compile` now does the right thing automatically, and the relevant config has been deprecated. Also fix links in float8 training benchmark README.md to point to updated locations. Test Plan: ``` ./test/float8/test_everything.sh ``` ``` // before with-proxy TORCHTITAN_ROOT=~/local/torchtitan/ FLOAT8_RECIPE_WITH_BEST_SETTINGS="tensorwise" ./torchtitan_benchmark.sh ... Median Tokens/Second (excluding step 1): 7999.0 Max Memory Usage: 36.68 GiB // after with-proxy TORCHTITAN_ROOT=~/local/torchtitan/ FLOAT8_RECIPE_WITH_BEST_SETTINGS="tensorwise" ./torchtitan_benchmark.sh ... Median Tokens/Second (excluding step 1): 8038.5 Max Memory Usage: 36.68 GiB ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 1211464 ghstack-comment-id: 3113439246 Pull Request resolved: #2594
danielvegamyhre
approved these changes
Jul 24, 2025
| - bf16 + compile: `TORCHTITAN_ROOT=<path> ./float8_training_benchmark.sh` | ||
| - float8 tensorwise with float8 all-gather + compile: `TORCHTITAN_ROOT=<path> FLOAT8_RECIPE_WITH_BEST_SETTINGS="tensorwise" ./float8_training_benchmark.sh` | ||
| - float8 rowwise with bf16 all-gather + compile: `TORCHTITAN_ROOT=<path> FLOAT8_RECIPE_WITH_BEST_SETTINGS="rowwise" ./float8_training_benchmark.sh` | ||
| 3. From the `torchao/benchmarks/float8/training/` directory, you can run the following commands to reproduce the benchmarks above: |
Contributor
There was a problem hiding this comment.
I think this should be ao/benchmarks/float8/training/ (repo is named ao and benchmarks dir is in the repo root dir). Same for other places in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removing code which we no longer need after
#2356 .
torch.compilenow does theright thing automatically, and the relevant config has been deprecated.
Also fix links in float8 training benchmark README.md to point to
updated locations.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: