Remove transpose_input from fbgemm configs#2422
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2422
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit ad1efd7 with merge base 2d61be8 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jerryzh168
added a commit
that referenced
this pull request
Jun 22, 2025
Summary: This is actually not needed since people can manually transpose the weights beforehand Test Plan: ``` python test/dtypes/test_fbgemm_fp8.py -k test_bmm python test/dtypes/test_fbgemm_int4.py -k test_bmm ``` Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2422, branch: jerryzh168/stack/2
0be4845 to
59acabd
Compare
jerryzh168
added a commit
that referenced
this pull request
Jun 22, 2025
Summary: This is actually not needed since people can manually transpose the weights beforehand Test Plan: ``` python test/dtypes/test_fbgemm_fp8.py -k test_bmm python test/dtypes/test_fbgemm_int4.py -k test_bmm ``` Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2422, branch: jerryzh168/stack/2
59acabd to
fbae7a1
Compare
jerryzh168
added a commit
that referenced
this pull request
Jun 23, 2025
Summary: This is actually not needed since people can manually transpose the weights beforehand Test Plan: ``` python test/dtypes/test_fbgemm_fp8.py -k test_bmm python test/dtypes/test_fbgemm_int4.py -k test_bmm ``` Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2422, branch: jerryzh168/stack/2
fbae7a1 to
8809c90
Compare
jerryzh168
added a commit
that referenced
this pull request
Jun 23, 2025
Summary: This is actually not needed since people can manually transpose the weights beforehand Test Plan: ``` python test/dtypes/test_fbgemm_fp8.py -k test_bmm python test/dtypes/test_fbgemm_int4.py -k test_bmm ``` Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2422, branch: jerryzh168/stack/2
8809c90 to
a7778a7
Compare
a7778a7 to
a856b3d
Compare
a856b3d to
9c2d239
Compare
9c2d239 to
ed83e0a
Compare
ed83e0a to
336cc66
Compare
7f8c910 to
9ab9044
Compare
Merged
9ab9044 to
b828ffc
Compare
Contributor
|
is this in the BC surface, or not yet? |
Contributor
Author
we haven't officially announced these, and these are not really used, but I'll need to update some checkpoints I think |
b828ffc to
5971b02
Compare
Summary: This is actually not needed since people can manually transpose the weights beforehand Test Plan: ``` python test/dtypes/test_fbgemm_fp8.py -k test_bmm python test/dtypes/test_fbgemm_int4.py -k test_bmm ``` Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2422, branch: jerryzh168/stack/2
5971b02 to
ad1efd7
Compare
drisspg
approved these changes
Jul 3, 2025
Contributor
Author
will quickly fix if there are any issues |
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
Summary: This is actually not needed since people can manually transpose the weights beforehand Test Plan: ``` python test/dtypes/test_fbgemm_fp8.py -k test_bmm python test/dtypes/test_fbgemm_int4.py -k test_bmm ``` Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2422, branch: jerryzh168/stack/2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
transpose_inputfrom fbgemm configs #2422Remove
transpose_inputfrom fbgemm configsSummary:
This is actually not needed since people can manually transpose the weights beforehand
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: