Add dynamic quantization support to gemlite layout#2327
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2327
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit a94c9cf with merge base dd22777 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
I think by "static" you meant weight only? |
jerryzh168
reviewed
Jun 6, 2025
Signed-off-by: mobicham <hicham@mobiuslabs.com>
jerryzh168
approved these changes
Jun 6, 2025
Contributor
Author
|
Anything else to have this merged? Thank you! |
Contributor
|
we can merge now, the test failures does not look related |
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
* fix get_plain() with FMA mode * update * fix in_features/out_feature meta-data mismatch * update gemlite slice test * add packing_bitwidth support * add packing_bitwidth support and cleanup * update default gemlite layout * cleanup * fix symmetric use-case and relax _same_meta_data * _copy() meta data * fix (4,) in autoquant * Add dynamic mode in gemlite layout * mode explanation Signed-off-by: mobicham <hicham@mobiuslabs.com> * use weights_only instead of static --------- Signed-off-by: mobicham <hicham@mobiuslabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds dynamic quantization support to the GemLite layout. The new config param is
mode:mode="weight_only"- no activation quantization (default).mode="dynamic"- uses int8 dynamic quantization for A8W8 and fp8 for A8Wn.