Fix slicing and get_plain() in GemLite#2288
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2288
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit b2892ce with merge base 35ffb26 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jerryzh168
approved these changes
Jun 2, 2025
Contributor
|
could you incorporate test into ao/test/dtypes/test_affine_quantized.py Line 363 in 8366465 |
Contributor
Author
|
Updated the test and successfully tested on vLLM. |
Contributor
Author
|
In vLLM, I get |
jerryzh168
reviewed
Jun 4, 2025
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
* fix get_plain() with FMA mode * update * fix in_features/out_feature meta-data mismatch * update gemlite slice test * add packing_bitwidth support * add packing_bitwidth support and cleanup * update default gemlite layout * cleanup * fix symmetric use-case and relax _same_meta_data * _copy() meta data * fix (4,) in autoquant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributions
Wq * s + zinstead of(W_q - z ) * s), so we need to updateget_plain()to make it compatible with both formats.get_plain()was causing vLLM issues.Notes
gemlite.set_kernel_caching(True)gives wrong output with torchao but not when using gemlite as a module, not sure why, but that would impact perf for batch-size=1 by up to 10 tokens/sec.Tests
End-2-End test
https://gist.github.com/mobicham/54fed6f18bee590f615f18391b45b71e
Slicing Test