unbreak CI by fixing MX tests#2208
Merged
Merged
Conversation
Summary: #2201 broke CI: 1. some MX tests for fp4 are running on A10G instances, with skipping not being properly applied (https://hud.pytorch.org/pytorch/ao/commit/4bfd7c09ef4592eacbbf990aea6d6bda608865c1#42164784332-box) 2. some SQNR thresholds were to tight for fp4 (https://hud.pytorch.org/pytorch/ao/commit/4bfd7c09ef4592eacbbf990aea6d6bda608865c1#42164784332-box) This PR fixes both of these to get CI back to green (I hope). Note that I can't repro 1 locally, so we'll have to land and see if it works. Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2208
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3339ac4 with merge base 58ac6c0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
approved these changes
May 14, 2025
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
Summary: #2201 broke CI: 1. some MX tests for fp4 are running on A10G instances, with skipping not being properly applied (https://hud.pytorch.org/pytorch/ao/commit/4bfd7c09ef4592eacbbf990aea6d6bda608865c1#42164784332-box) 2. some SQNR thresholds were to tight for fp4 (https://hud.pytorch.org/pytorch/ao/commit/4bfd7c09ef4592eacbbf990aea6d6bda608865c1#42164784332-box) This PR fixes both of these to get CI back to green (I hope). Note that I can't repro 1 locally, so we'll have to land and see if it works. Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
#2201 broke CI:
This PR fixes both of these to get CI back to green (I hope). Note that I can't repro 1 locally, so we'll have to land and see if it works.
Test Plan: CI
Reviewers:
Subscribers:
Tasks:
Tags: