Add gemm for fp32_a_int8_b matmul kernel#2039
Merged
Merged
Conversation
Summary: Using gemmv for prefill is extremely slow. As it turns out, shown later in the stack, dequantizing v matrix is still better because at 3k context prefill we are heavily bound by compute Reviewed By: metascroy Differential Revision: D71833070
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2039
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit 2e476fa with merge base a3b857f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71833070 |
guangy10
approved these changes
Apr 10, 2025
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
Differential Revision: D71833070 Pull Request resolved: #2039
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Using gemmv for prefill is extremely slow. As it turns out, shown later in the stack, dequantizing v matrix is still better because at 3k context prefill we are heavily bound by compute
Reviewed By: metascroy
Differential Revision: D71833070