Skip to content

enable mxfp8_cublas recipe in roofline script#1843

Merged
vkuzo merged 34 commits into
mainfrom
gh/vkuzo/54/head
Mar 11, 2025
Merged

enable mxfp8_cublas recipe in roofline script#1843
vkuzo merged 34 commits into
mainfrom
gh/vkuzo/54/head

Conversation

@vkuzo

@vkuzo vkuzo commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

Summary:

Enables us to see roofline vs actual performance of this recipe

Test Plan:

python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 21 commits March 4, 2025 12:53
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo

vkuzo commented Mar 5, 2025

Copy link
Copy Markdown
Contributor Author

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-bot Bot commented Mar 5, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1843

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 5, 2025
vkuzo added a commit that referenced this pull request Mar 5, 2025
Summary:

Enables us to see roofline vs actual performance of this recipe

Test Plan:

```
python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 2da390c
ghstack-comment-id: 2701761490
Pull Request resolved: #1843
vkuzo added 2 commits March 5, 2025 10:39
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 5, 2025
Summary:

Enables us to see roofline vs actual performance of this recipe

Test Plan:

```
python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ea3dda7
ghstack-comment-id: 2701761490
Pull Request resolved: #1843
@vkuzo vkuzo added the module: not user facing Use this tag if you don't want this PR to show up in release notes label Mar 5, 2025
@vkuzo vkuzo requested review from danielvegamyhre and drisspg March 5, 2025 18:40
vkuzo added 2 commits March 5, 2025 10:57
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 5, 2025
Summary:

Enables us to see roofline vs actual performance of this recipe

Test Plan:

```
python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: a26ad14
ghstack-comment-id: 2701761490
Pull Request resolved: #1843
vkuzo added 2 commits March 5, 2025 11:48
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 5, 2025
Summary:

Enables us to see roofline vs actual performance of this recipe

Test Plan:

```
python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 1e5a431
ghstack-comment-id: 2701761490
Pull Request resolved: #1843
vkuzo added 2 commits March 5, 2025 11:49
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 5, 2025
Summary:

Enables us to see roofline vs actual performance of this recipe

Test Plan:

```
python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: c4c0cd3
ghstack-comment-id: 2701761490
Pull Request resolved: #1843
vkuzo added 2 commits March 6, 2025 05:45
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 6, 2025
Summary:

Enables us to see roofline vs actual performance of this recipe

Test Plan:

```
python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 829d32d
ghstack-comment-id: 2701761490
Pull Request resolved: #1843
vkuzo added 2 commits March 11, 2025 07:57
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 11, 2025
Summary:

Enables us to see roofline vs actual performance of this recipe

Test Plan:

```
python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: bcf98e4
ghstack-comment-id: 2701761490
Pull Request resolved: #1843
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/53/head to main March 11, 2025 14:59
vkuzo added a commit that referenced this pull request Mar 11, 2025
Summary:

Enables us to see roofline vs actual performance of this recipe

Test Plan:

```
python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: bcf98e4
ghstack-comment-id: 2701761490
Pull Request resolved: #1843
@vkuzo vkuzo merged commit d3b481b into main Mar 11, 2025
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants