[float8] add float8 training benchmarking scripts#1802
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1802
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 51a9780 with merge base 890e0ac ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
d63c7fa to
009b331
Compare
vkuzo
reviewed
Mar 1, 2025
| @@ -0,0 +1,18 @@ | |||
| # Float8 training benchmarking | |||
Contributor
There was a problem hiding this comment.
nit: move this to benchmarks/float8/something?
vkuzo
reviewed
Mar 1, 2025
|
|
||
| # validate recipe name | ||
| if [ -n "${FLOAT8_RECIPE}" ]; then | ||
| if [ "$FLOAT8_RECIPE" != "rowwise" ] && [ "$FLOAT8_RECIPE" != "tensorwise" ]; then |
Contributor
There was a problem hiding this comment.
nit: this is already checked twice (once in torchtitan, once in Float8LinearConfig), IMO we don't need to check it a third time :)
vkuzo
approved these changes
Mar 1, 2025
vkuzo
left a comment
Contributor
There was a problem hiding this comment.
looks great! Let's just move to benchmarks/float8
Contributor
Author
|
Looks like test failure is due to #1799 and unrelated to this change. Going to merge |
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
* add float8 training benchmarking scripts * move to benchmarks/float8/training
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Usage
Example