Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1563
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit 38cab14 with merge base b3deb16 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Merged
28b5766 to
f587e6e
Compare
| @parameterized.expand(COMMON_DEVICE_DTYPE) | ||
| @unittest.skipIf(not TORCH_VERSION_AT_LEAST_2_3, "int4 requires torch nightly.") | ||
| # @unittest.skipIf(TORCH_VERSION_AT_LEAST_2_5, "int4 skipping 2.5+ for now") | ||
| @skip_if_rocm("ROCm development in progress") |
There was a problem hiding this comment.
"ROCm enablement in progress" would be a better comment.
pruthvistony
approved these changes
Jan 17, 2025
pruthvistony
left a comment
There was a problem hiding this comment.
ROCm CI enable-ment in progress. So skipping few UTs temporary, to be debugged and fixed in further PRs.
Contributor
|
This caused CI to fail: I'm reverting this for now |
andrewor14
added a commit
that referenced
this pull request
Jan 17, 2025
This reverts commit a1c67b9.
andrewor14
added a commit
that referenced
this pull request
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the unit tests for ROCm CI deployment. refer to #999
This pull request introduces a decorator to skip tests on the ROCm platform and applies this decorator across multiple test files. The most important changes include the addition of the
skip_if_rocmdecorator and its application to various test functions to handle ROCm-specific issues.Introduction of
skip_if_rocmdecorator:test/test_utils.py: Added theskip_if_rocmdecorator to skip tests on the ROCm platform with a custom message.Application of
skip_if_rocmdecorator:test/dtypes/test_affine_quantized.py: Applied@skip_if_rocmto multiple test functions and imports. [1] [2] [3] [4]test/dtypes/test_floatx.py: Applied@skip_if_rocmto test functions and imports. [1] [2]test/float8/test_base.py: Applied@skip_if_rocmto test functions and imports. [1] [2]test/hqq/test_hqq_affine.py: Applied@skip_if_rocmto test functions and imports. [1] [2]test/integration/test_integration.py: Applied@skip_if_rocmto multiple test functions and imports. [1] [2] [3] [4] [5] [6]test/kernel/test_galore_downproj.py: Applied@skip_if_rocmto test functions and imports. [1] [2]test/prototype/test_awq.py: Applied@skip_if_rocmto test functions and imports. [1] [2]test/prototype/test_low_bit_optim.py: Applied@skip_if_rocmto test functions and imports. [1] [2]test/prototype/test_splitk.py: Applied@skip_if_rocmto test functions and imports. (test/prototype/test_splitk.pyL17-R23, F6c2ed6dL19R19)test/quantization/test_galore_quant.py: Applied@skip_if_rocmto test functions and imports. [1] [2]test/quantization/test_marlin_qqq.py: Applied@skip_if_rocmto test functions and imports. [1] [2] [3]test/sparsity/test_marlin.py: Applied@skip_if_rocmto test functions and imports. [1] [2] [3]test/test_ops.py: Added a module-level skip for ROCm.test/test_s8s4_linear_cutlass.py: Added a module-level skip for ROCm.