Skip to content

Additional fixes for autoquant serialization#1486

Merged
jerryzh168 merged 1 commit into
pytorch:mainfrom
jerryzh168:autoquant-ser-additional
Jan 3, 2025
Merged

Additional fixes for autoquant serialization#1486
jerryzh168 merged 1 commit into
pytorch:mainfrom
jerryzh168:autoquant-ser-additional

Conversation

@jerryzh168

Copy link
Copy Markdown
Contributor

Summary:
Can't overwrite .layout attribute of a Tensor since tensor.layout should be torch.layout

discovered when loading the autoquantized model https://huggingface.co/jerryzh168/llama3-8b-autoquant

Test Plan:
tested locally with huggingface transformers
Reviewers:

Subscribers:

Tasks:

Tags:

Summary:
Can't overwrite `.layout` attribute of a Tensor since `tensor.layout` should be `torch.layout`

discovered when loading the autoquantized model https://huggingface.co/jerryzh168/llama3-8b-autoquant

Test Plan:
tested locally with huggingface transformers
Reviewers:

Subscribers:

Tasks:

Tags:
@pytorch-bot

pytorch-bot Bot commented Jan 3, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1486

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 7688389 with merge base d9fe2c2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jerryzh168 jerryzh168 requested a review from HDCharles January 3, 2025 17:34
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025
@jerryzh168 jerryzh168 requested review from cpuhrsch and drisspg January 3, 2025 17:34
@jerryzh168 jerryzh168 added the topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) label Jan 3, 2025

@drisspg drisspg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L

@jerryzh168 jerryzh168 merged commit c59bce5 into pytorch:main Jan 3, 2025
amdfaa pushed a commit that referenced this pull request Jan 10, 2025
Summary:
Can't overwrite `.layout` attribute of a Tensor since `tensor.layout` should be `torch.layout`

discovered when loading the autoquantized model https://huggingface.co/jerryzh168/llama3-8b-autoquant

Test Plan:
tested locally with huggingface transformers
Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants