Gemlite fixes#1432
Closed
HDCharles wants to merge 1 commit into
Closed
Conversation
Summary: shapes need to be divisible by 128 or they will not work with gemlite need fp32 accumulation for groupsize None on int4 Test Plan: python test_integration.py -k "test_gemlite" (new test for non divisible shape)a python generate.py --checkpoint_path $CHECKPOINT_PATH/$MODEL_REPO/model.pth --compile --precision float16 --quantization gemlite-8-4-None --write_result benchmark_results.txt python generate.py --checkpoint_path $CHECKPOINT_PATH/$MODEL_REPO/model.pth --compile --precision float16 --quantization gemlite-32-4-None --write_result benchmark_results.txta (previously these gave nonsense responses) Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1432
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 1797c75 with merge base 33d57af ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jerryzh168
reviewed
Dec 18, 2024
| return abs(other_event.event_time - self.event_time) * 1000 | ||
|
|
||
|
|
||
| def get_arch_name() -> str: |
Contributor
There was a problem hiding this comment.
why these changes? is this some rebase issue
jerryzh168
added a commit
to jerryzh168/ao
that referenced
this pull request
Dec 18, 2024
Summary: Resubmitting fixes from @HDCharles in pytorch#1432 since that seems to have issues with rebase Test Plan: see pytorch#1432 Reviewers: Subscribers: Tasks: Tags:
mobicham
reviewed
Dec 18, 2024
| if _layout.group_size == None and _layout.bit_width == 4: | ||
| from gemlite.core import GEMLITE_ACC_DTYPE | ||
| from gemlite.dtypes import DType | ||
| GEMLITE_ACC_DTYPE[DType.FP16] = DType.FP32 |
Contributor
There was a problem hiding this comment.
This will only work when all the layers use the same group_size, which is ok for now.
The other option will be using this https://github.com/mobiusml/gemlite/blob/master/gemlite/core.py#L87 but for now let's keep it like this
Contributor
Author
There was a problem hiding this comment.
I tested this manually, it works in all cases even when there are different group sizes.
Contributor
There was a problem hiding this comment.
I mean when different layers use different settings within the same model, but let's not worry about that !
jerryzh168
added a commit
to jerryzh168/ao
that referenced
this pull request
Dec 18, 2024
Summary: Resubmitting pytorch#1432 since it has some rebase issues and we want to merge the fix asap Test Plan: see pytorch#1432 Reviewers: Subscribers: Tasks: Tags:
Merged
jerryzh168
added a commit
that referenced
this pull request
Dec 18, 2024
Contributor
|
landed in #1435, please feel free to submit any follow up fixes |
amdfaa
pushed a commit
that referenced
this pull request
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
shapes need to be divisible by 128 or they will not work with gemlite need fp32 accumulation for groupsize None on int4
Test Plan:
python test_integration.py -k "test_gemlite" (new test for non divisible shape)a
python generate.py --checkpoint_path $CHECKPOINT_PATH/$MODEL_REPO/model.pth --compile --precision float16 --quantization gemlite-8-4-None --write_result benchmark_results.txt python generate.py --checkpoint_path
$CHECKPOINT_PATH/$MODEL_REPO/model.pth --compile --precision float16 --quantization gemlite-32-4-None --write_result benchmark_results.txta
(previously these gave nonsense responses)
Reviewers:
Subscribers:
Tasks:
Tags: