Update SAM AMG README with more descriptive install instructions#1337
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1337
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 3dcb54f with merge base ed76e9c ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cpuhrsch
reviewed
Nov 25, 2024
cpuhrsch
reviewed
Nov 25, 2024
cpuhrsch
reviewed
Nov 25, 2024
cpuhrsch
reviewed
Nov 25, 2024
cpuhrsch
reviewed
Nov 25, 2024
| cd examples/sam2_amg_server/ | ||
| ``` | ||
|
|
||
| Download `sam2.1_hiera_large.pt` from https://github.com/facebookresearch/sam2?tab=readme-ov-file#download-checkpoints and put it into `~/checkpoints/sam2` |
Contributor
There was a problem hiding this comment.
The download part I guess doesn't apply anymore now that the user can get this via the model type argument.
cpuhrsch
approved these changes
Nov 26, 2024
Contributor
|
Looks good, let me know once you got a chance to give this another commit or two and then we can merge. |
cpuhrsch
reviewed
Nov 27, 2024
| # Model | ||
| model: | ||
| _target_: sam2.modeling.sam2_base.SAM2Base | ||
| _target_: torchao._models.sam2.modeling.sam2_base.SAM2Base |
Contributor
There was a problem hiding this comment.
Ah, these are the sam2 configs. There's sam2 and then there's sam2.1. I had to switched to sam2.1, but maybe sam2 is still useful? I updated the sam2.1 configs in b2e42ff#diff-12caf984b30e7028df7fb867a984c5ccad3fde0a0783df2af26db9cef860fbe5 , but in any case it doesn't hurt to have sam2 support as well.
cpuhrsch
reviewed
Nov 27, 2024
jerryzh168
reviewed
Nov 27, 2024
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
…h#1337) * [AOTI] Remove the original model weights in Python deployment Summary: Fixes pytorch/torchchat#1302. Because AOTI-compiled model contains a copy of model weights, we need to release the corresponding eager model weights in the Python deployment path. * Revert "[AOTI] Remove the original model weights in Python deployment" This reverts commit 962ec0d913bbf6c30496560f12b4726445dce7da. * Refactor the code * Add setup_cache for aoti_package_path --------- Co-authored-by: Jack-Khuu <jack.khuu.7@gmail.com>
bhack
reviewed
Dec 9, 2024
bhack
left a comment
There was a problem hiding this comment.
Can we recap in the Readme also the optimizations we have introduced with AO?
Contributor
|
@bhack - Yes, we're working a more detailed description of this. |
amdfaa
pushed a commit
that referenced
this pull request
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cpuhrsch
Installing was not so obvious, so this should help others trying to test and contribute.
There's some extra commits from amending, I'm still kinda garbage at git