Removal of BAZEL build files from python package and changes to make cpp tests work#3641
Merged
Removal of BAZEL build files from python package and changes to make cpp tests work#3641
Conversation
356899f to
7024bf2
Compare
Once the wheel is built, the Bazel files are no longer needed. Fixes #3477
5f27f63 to
5eac5e5
Compare
narendasan
reviewed
Aug 1, 2025
third_party/BUILD
Outdated
| @@ -0,0 +1,53 @@ | |||
| load("@rules_cc//cc:cc_library.bzl", "cc_library") | |||
Collaborator
There was a problem hiding this comment.
Move this to `//third_party/torch_tensorrt/BUILD
narendasan
reviewed
Aug 1, 2025
docker/MODULE.bazel.ngc
Outdated
| local_repository( | ||
| new_local_repository( | ||
| name = "torch_tensorrt", | ||
| build_file = "@//third_party:BUILD", |
Collaborator
There was a problem hiding this comment.
Adjust this path accordingly
narendasan
reviewed
Aug 1, 2025
narendasan
reviewed
Aug 7, 2025
narendasan
reviewed
Aug 7, 2025
Collaborator
narendasan
left a comment
There was a problem hiding this comment.
Minor stuff then good to merge
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #3615