Temporary fix to workaround the mutable decomposition error.#3636
Merged
lanluo-nvidia merged 4 commits intomainfrom Jun 30, 2025
Merged
Temporary fix to workaround the mutable decomposition error.#3636lanluo-nvidia merged 4 commits intomainfrom
lanluo-nvidia merged 4 commits intomainfrom
Conversation
narendasan
reviewed
Jun 30, 2025
py/torch_tensorrt/dynamo/runtime/_MutableTorchTensorRTModule.py
Outdated
Show resolved
Hide resolved
py/torch_tensorrt/dynamo/runtime/_MutableTorchTensorRTModule.py
Outdated
Show resolved
Hide resolved
narendasan
reviewed
Jun 30, 2025
Collaborator
|
LGTM after Naren's comments |
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/runtime/_MutableTorchTensorRTModule.py 2025-06-30 20:42:14.145185+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/runtime/_MutableTorchTensorRTModule.py 2025-06-30 20:42:41.576462+00:00
@@ -475,11 +475,13 @@
f"Invalid input type {type(inputs)} encountered in the input. "
+ "Allowed input types: {torch_tensorrt.Input, torch.Tensor, list, tuple, dict}"
)
def forward(self, *args: Any, **kwargs: Any) -> Any:
- warnings.warn("Direct calls to {self.__class__}.forward() are currently broken by due to https://github.com/pytorch/pytorch/issues/157183. Either call {self.__class__}(...) directly or use {self.__class__}._forward as a work around")
+ warnings.warn(
+ "Direct calls to {self.__class__}.forward() are currently broken by due to https://github.com/pytorch/pytorch/issues/157183. Either call {self.__class__}(...) directly or use {self.__class__}._forward as a work around"
+ )
return self._forward(*args, **kwargs)
def _forward(self, *args: Any, **kwargs: Any) -> Any:
# Step 1: Check whether the input shape has changed
kwargs = MutableTorchTensorRTModule._process_kwarg_inputs(kwargs)
apbose
pushed a commit
that referenced
this pull request
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: