Conversation
zewenli98
approved these changes
May 18, 2024
Collaborator
zewenli98
left a comment
There was a problem hiding this comment.
Just a minor comment. The others LGTM. Can you merge it after fixing the functions' names?
|
|
||
|
|
||
| @dynamo_tensorrt_converter(torch.ops.aten.log2.default) | ||
| def log2( |
Collaborator
There was a problem hiding this comment.
I just noticed the naming was inconsistent. Can you modify the function name to aten_ops_log2?
|
|
||
|
|
||
| @dynamo_tensorrt_converter(torch.ops.aten.log10.default) | ||
| def log10( |
Collaborator
There was a problem hiding this comment.
Same as above. log10 -> aten_ops_log10
laikhtewari
pushed a commit
that referenced
this pull request
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A converter for the torch.ops.aten.log1p operation (elementwise log(1 + x))
Fixes # (issue)
Type of change
Checklist: