Merged
Conversation
37d1674 to
ad9896a
Compare
peri044
reviewed
Apr 26, 2024
peri044
requested changes
Apr 26, 2024
Collaborator
peri044
left a comment
There was a problem hiding this comment.
- Can you add tensorrt==10.0.1.6 in our py/requirements.txt ? (https://github.com/pytorch/TensorRT/blob/trt_10_ga_cloned_from_main/py/requirements.txt)
- Also update trt version in dev_dep_versions.yml (https://github.com/pytorch/TensorRT/blob/trt_10_ga_cloned_from_main/dev_dep_versions.yml)
c7a5a3b to
3866636
Compare
peri044
approved these changes
Apr 26, 2024
Collaborator
peri044
left a comment
There was a problem hiding this comment.
Changes LGTM. pending rebase
3866636 to
0e6aada
Compare
narendasan
reviewed
Apr 26, 2024
narendasan
reviewed
Apr 26, 2024
5079c1c to
20b34e2
Compare
HolyWu
reviewed
Apr 27, 2024
Contributor
|
Line 45 in 20b34e2 |
Collaborator
Author
|
@HolyWu Made the changes. Thanks for the review! |
HolyWu
reviewed
Apr 27, 2024
fd77a55 to
35461e1
Compare
35461e1 to
1dc194a
Compare
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_dyn_models.py 2024-04-29 19:55:18.604129+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_dyn_models.py 2024-04-29 19:57:14.310783+00:00
@@ -7,13 +7,11 @@
from torch_tensorrt.dynamo.utils import COSINE_THRESHOLD, cosine_similarity
assertions = unittest.TestCase()
-@unittest.skip(
- "Skipping this test for now due to a bug"
-)
+@unittest.skip("Skipping this test for now due to a bug")
@pytest.mark.unit
def test_base_dynamic(ir):
"""
Tests the model (which is fully convertible) with dynamic shapes
"""
@@ -67,13 +65,11 @@
with torch.no_grad():
torch.cuda.empty_cache()
-@unittest.skip(
- "Skipping this test for now due to a bug"
-)
+@unittest.skip("Skipping this test for now due to a bug")
@pytest.mark.unit
def test_base_dynamic_fallback(ir):
"""
Tests the model with dynamic shapes where torch.abs op is forced to run in PyTorch
"""f8acc75 to
a777795
Compare
narendasan
reviewed
Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR runs CI to test TRT-10 GA support for main branch.