fix: param bug in test_binary_ops_aten#2733
Merged
zewenli98 merged 1 commit intopytorch:mainfrom Apr 16, 2024
Merged
Conversation
gs-olive
approved these changes
Apr 9, 2024
Contributor
gs-olive
left a comment
There was a problem hiding this comment.
Looks good to me! Were these tests getting skipped before?
Collaborator
Author
I think so. Not sure why they were skipped in CI |
peri044
pushed a commit
that referenced
this pull request
Apr 19, 2024
laikhtewari
pushed a commit
that referenced
this pull request
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a param bug in
test_binary_ops_aten. The param is required to be a tuple instead of a single value.Fixes # (issue)
Type of change
Checklist: