Merged
Conversation
Closed
zewenli98
reviewed
Mar 27, 2024
Collaborator
zewenli98
left a comment
There was a problem hiding this comment.
LGTM! Just one comment below.
| input: TRTTensor, | ||
| ) -> TRTTensor: | ||
| # False for NaN elements since NaN is not equal to anything, including itself. | ||
| equality_result = impl.elementwise.ops.eq( |
Collaborator
There was a problem hiding this comment.
For consistency, you can directly call impl.elementwise.eq() because the eq is exposed.
Collaborator
Author
There was a problem hiding this comment.
Thank you! I changed it!
peri044
pushed a commit
that referenced
this pull request
Apr 19, 2024
laikhtewari
pushed a commit
that referenced
this pull request
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In TRT, there isn't a direct way to check for NaN values, so I used a clever method. This method involves comparing the tensor to itself; input == input will only be false when dealing with NaN values.
Fixes # (issue)
Type of change
Checklist: