fix: Fix deconv kernel channel num_output_maps where wts are ITensor#2678
Merged
peri044 merged 1 commit intopytorch:mainfrom May 22, 2024
Merged
fix: Fix deconv kernel channel num_output_maps where wts are ITensor#2678peri044 merged 1 commit intopytorch:mainfrom
peri044 merged 1 commit intopytorch:mainfrom
Conversation
Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
Contributor
Author
|
Hi @bowang007 Request you to please review this PR for merge? |
peri044
approved these changes
May 22, 2024
Collaborator
peri044
left a comment
There was a problem hiding this comment.
Thanks. LGTM. I verified the test passes on local
laikhtewari
pushed a commit
that referenced
this pull request
May 24, 2024
…2678) Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
In current implementation deconv layer picks up the in_channel for kernel incorrectly when weight is also an ITensor.
This PR fixes that issue.
Conv2d
ConvTranspose2d
For conv2d the kernel dimensions are: [out_channels, in_channels / group, ... ]
For convTranspose2d the kernel dimension should be: [in_channel, out_channels / group, ... ]
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: