Skip to content

fix: Add cmake missing source file ref for core_lowering.passes#2672

Merged
narendasan merged 1 commit intopytorch:mainfrom
Arktische:fix_cmake_build
Mar 22, 2024
Merged

fix: Add cmake missing source file ref for core_lowering.passes#2672
narendasan merged 1 commit intopytorch:mainfrom
Arktische:fix_cmake_build

Conversation

@Arktische
Copy link
Copy Markdown
Contributor

@Arktische Arktische commented Mar 6, 2024 •
edited
Loading

Description

Add missing source file core/lowering/passes/unpack_scaled_dot_product_attention.cpp to core/lowering/passes/CMakeLists.txt. If not do so, when building shared library torchtrt will fail due to missing reference to function UnpackScaledDotProductAttention.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have added the relevant labels to my PR in so that relevant reviewers are notified
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: core Issues re: The core compiler labels Mar 6, 2024
@github-actions github-actions bot requested a review from gs-olive March 6, 2024 04:49
narendasan
narendasan approved these changes Mar 6, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@narendasan narendasan merged commit a2e76a8 into pytorch:main Mar 22, 2024
peri044 pushed a commit that referenced this pull request Apr 19, 2024
@Arktische @peri044
fix: Add cmake missing source file ref for core_lowering.passes (#2672)
e150913
laikhtewari pushed a commit that referenced this pull request May 24, 2024
@Arktische @laikhtewari
fix: Add cmake missing source file ref for core_lowering.passes (#2672)
820f111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan narendasan approved these changes

@gs-olive gs-olive Awaiting requested review from gs-olive

Assignees

No one assigned

Labels

cla signed component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Arktische @narendasan @facebook-github-bot