Skip to content

fix: Reorganize Dynamo directory + backends#1928

Merged
gs-olive merged 2 commits intopytorch:mainfrom
gs-olive:dynamo_refactoring
May 18, 2023
Merged

fix: Reorganize Dynamo directory + backends#1928
gs-olive merged 2 commits intopytorch:mainfrom
gs-olive:dynamo_refactoring

Conversation

@gs-olive
Copy link
Copy Markdown
Contributor

@gs-olive gs-olive commented May 17, 2023 •
edited
Loading

Description

  • Rename key backends to establish default backend and optional alternatives
  • Update function headers and docstrings, as well as key imports
  • Rename torch_compile folder to backend in accordance with torch.compile terminology
  • Update references throughout codebase
  • Specify certain functions as private/helper via underscore

Type of change

  • Code Restructuring

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this May 17, 2023
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label May 17, 2023
@gs-olive gs-olive force-pushed the dynamo_refactoring branch from 503992a to 7d658d6 Compare May 17, 2023 21:21
gs-olive
gs-olive commented May 17, 2023
View reviewed changes
py/torch_tensorrt/dynamo/backend/backends.py


def compile_module(
def _compile_module(
Copy link
Copy Markdown
Contributor Author

@gs-olive gs-olive May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added "_" to name, as the function is intended only for internal/helper use (requires a pre-traced FX GraphModule)

@gs-olive gs-olive force-pushed the dynamo_refactoring branch 2 times, most recently from 2eaf7ca to 05f2812 Compare May 18, 2023 00:25
@gs-olive
fix: Reorganize Dynamo backends
608c3ed 
- Rename key backends to establish default backend and optional
alternatives
- Update function headers and docstrings, as well as key imports
- Rename `torch_compile` folder to `backends` in accordance with
`torch.compile` terminology
- Update references throughout codebase
- Specify certain functions as private/helper via underscore
- Update tests and defaults to match expected number of engines to
generate
@gs-olive gs-olive force-pushed the dynamo_refactoring branch from 05f2812 to 608c3ed Compare May 18, 2023 01:20
@gs-olive gs-olive merged commit cf1f637 into pytorch:main May 18, 2023
@gs-olive gs-olive deleted the dynamo_refactoring branch May 18, 2023 19:37
gs-olive added a commit that referenced this pull request May 18, 2023
@gs-olive
fix: Reorganize Dynamo directory + backends (#1928)
a1bfda6
@gs-olive gs-olive mentioned this pull request May 18, 2023
Merged
narendasan pushed a commit that referenced this pull request May 30, 2023
@gs-olive @narendasan
fix: Reorganize Dynamo directory + backends (#1928)
c989739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gs-olive gs-olive

Labels

cla signed component: api [Python] Issues re: Python API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gs-olive @facebook-github-bot