Reorg for converters tanh (FX Converter Refactor [4/N]) <Target: converter_reorg_proto>#1900
Merged
narendasan merged 1 commit intomainfrom May 30, 2023
Merged
Conversation
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- py/torch_tensorrt/fx/converters/nn_ops_converters.py 2023-05-10 05:47:14.709796 +0000
+++ py/torch_tensorrt/fx/converters/nn_ops_converters.py 2023-05-10 05:47:33.434505 +0000
@@ -33,6 +33,6 @@
network=network,
target="torch.nn.modules.activation.Tanh",
source_ir=SourceIR.NN,
name=layer_name,
input_val=kwargs["input"],
- )
\ No newline at end of file
+ )
--- py/torch_tensorrt/fx/test/converters/aten_op/test_tanh_aten.py 2023-05-10 05:47:14.717797 +0000
+++ py/torch_tensorrt/fx/test/converters/aten_op/test_tanh_aten.py 2023-05-10 05:47:35.200839 +0000
@@ -46,6 +46,6 @@
TestModule(), input_specs, expected_ops={torch.ops.aten.tanh.default}
)
if __name__ == "__main__":
- run_tests()
\ No newline at end of file
+ run_tests()
Collaborator
|
@apbose please run linting. |
narendasan
reviewed
May 12, 2023
py/setup.py
Outdated
| cmd.append("--platforms=//toolchains:ci_rhel_x86_64_linux") | ||
| print("CI based build") | ||
|
|
||
| cmd.append("--jobs=4") |
Collaborator
There was a problem hiding this comment.
Why was this change added?
1696cd2 to
12f545c
Compare
634d312 to
5c5e1ba
Compare
5c5e1ba to
4b4a1b4
Compare
wushirong
approved these changes
May 30, 2023
Correcting linting error correction nn_ops_converters Undoing setup.py change mistake
4b4a1b4 to
13296a0
Compare
narendasan
pushed a commit
that referenced
this pull request
Jun 2, 2023
…erter_reorg_proto> (#1900)
narendasan
pushed a commit
that referenced
this pull request
Jun 2, 2023
…erter_reorg_proto> (#1900)
narendasan
pushed a commit
that referenced
this pull request
Jun 3, 2023
…erter_reorg_proto> (#1900)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.