refactor: Centralizing sigmoid implementation (FX Converter Refactor [2/N]) <Target: converter_reorg_proto> by narendasan · Pull Request #1868 · pytorch/TensorRT

narendasan · 2023-04-28T20:27:06Z

Description

Centralizes the sigmoid converters into one implementation

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

Refactor

Checklist:

My code follows the style guidelines of this project (You can use the linters)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas and hacks
I have made corresponding changes to the documentation
I have added tests to verify my fix or my feature
New and existing unit tests pass locally with my changes
I have added the relevant labels to my PR in so that relevant reviewers are notified

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

py/torch_tensorrt/fx/converters/acc_ops_converters.py

py/torch_tensorrt/fx/test/converters/aten_op/test_sigmoid_aten.py

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

narendasan · 2023-05-20T23:41:58Z

@wushirong Can you review this PR. This is gating release of 1.4

wushirong · 2023-05-23T20:33:46Z

can you check the comment on the adding fb16 test cases? once we get this, I think the diff is good to go.

Signed-off-by: Naren Dasan <naren@narendasan.com>

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

…[2/N]) <Target: converter_reorg_proto> (#1868) Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>

narendasan requested review from frank-wei and wushirong April 28, 2023 20:27

facebook-github-bot added cla signed fx labels Apr 28, 2023

github-actions bot added component: api [Python] Issues re: Python API component: fx labels Apr 28, 2023

github-actions bot requested a review from yinghai April 28, 2023 20:27

github-actions bot approved these changes Apr 28, 2023

View reviewed changes

narendasan changed the title ~~refactor: Centralizing sigmoid implementation [2/N]~~ refactor: Centralizing sigmoid implementation (FX Converter Refactor [2/N]) Apr 28, 2023

github-actions bot approved these changes Apr 28, 2023

View reviewed changes

narendasan added the Story: ATen Op Support label Apr 28, 2023

narendasan force-pushed the converter_reorg_proto branch 2 times, most recently from c438fe2 to 9cec91e Compare April 28, 2023 22:55

narendasan force-pushed the converter_reorg_sigmoid branch from 0d09d52 to 887610b Compare April 28, 2023 23:04

github-actions bot approved these changes Apr 28, 2023

View reviewed changes

narendasan force-pushed the converter_reorg_proto branch from 9cec91e to 9864d96 Compare April 28, 2023 23:28

narendasan force-pushed the converter_reorg_sigmoid branch from 887610b to 00a0e39 Compare April 28, 2023 23:28

github-actions bot approved these changes Apr 28, 2023

View reviewed changes

narendasan force-pushed the converter_reorg_proto branch from 9864d96 to 8822b66 Compare May 1, 2023 16:23

narendasan force-pushed the converter_reorg_sigmoid branch from 00a0e39 to 56fbc9f Compare May 1, 2023 16:24

github-actions bot approved these changes May 1, 2023

View reviewed changes

narendasan force-pushed the converter_reorg_sigmoid branch from 56fbc9f to ece6b1a Compare May 1, 2023 17:36

github-actions bot approved these changes May 1, 2023

View reviewed changes

narendasan force-pushed the converter_reorg_proto branch from 8822b66 to 1696cd2 Compare May 1, 2023 19:57

narendasan force-pushed the converter_reorg_sigmoid branch from ece6b1a to 6cf5ffd Compare May 1, 2023 20:20

github-actions bot approved these changes May 1, 2023

View reviewed changes

wushirong reviewed May 4, 2023

View reviewed changes

py/torch_tensorrt/fx/converters/acc_ops_converters.py Show resolved Hide resolved

py/torch_tensorrt/fx/test/converters/aten_op/test_sigmoid_aten.py Show resolved Hide resolved

wushirong mentioned this pull request May 5, 2023

Reorg for converters in (FX Converter Refactor [1/N]) #1867

Merged

7 tasks

narendasan changed the title ~~refactor: Centralizing sigmoid implementation (FX Converter Refactor [2/N])~~ refactor: Centralizing sigmoid implementation (FX Converter Refactor [2/N]) <Target: converter_reorg_proto> May 12, 2023

gs-olive force-pushed the converter_reorg_proto branch from 1696cd2 to 12f545c Compare May 15, 2023 21:25

gs-olive force-pushed the converter_reorg_sigmoid branch from 6cf5ffd to 3ec137b Compare May 15, 2023 21:32

github-actions bot approved these changes May 15, 2023

View reviewed changes

narendasan changed the base branch from converter_reorg_proto to main May 23, 2023 20:42

refactor: Centralizing sigmoid implementation

9eabefd

Signed-off-by: Naren Dasan <naren@narendasan.com>

narendasan force-pushed the converter_reorg_sigmoid branch from 3ec137b to 9eabefd Compare May 23, 2023 20:49

github-actions bot approved these changes May 23, 2023

View reviewed changes

tests: FP16 test for sigmoid

c3c0fe8

Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>

github-actions bot approved these changes May 24, 2023

View reviewed changes

narendasan merged commit 5be3b58 into main May 25, 2023

narendasan deleted the converter_reorg_sigmoid branch May 25, 2023 18:15

Conversation

narendasan commented Apr 28, 2023

Description

Type of change

Checklist:

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

narendasan commented May 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wushirong commented May 23, 2023

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

narendasan commented May 20, 2023 •

edited

Loading