fix: Repair invalid schema arising from lowering pass#1786
Merged
gs-olive merged 1 commit intopytorch:mainfrom Mar 30, 2023
Merged
fix: Repair invalid schema arising from lowering pass#1786gs-olive merged 1 commit intopytorch:mainfrom
gs-olive merged 1 commit intopytorch:mainfrom
Conversation
- When `remove_unnecessary_casts` replaces both tensors in an `aten::div` call with the corresponding scalars, and the rounding mode (third argument) is specified, the schema becomes invalid - To avoid this, we intercept the call and split the result based on what the third argument in the input was, either delegating the result to `aten::Int(aten::div(...))`, for "trunc" or `aten::floordiv(...)` for "floor" - Update lowering pass to incorporate the above change, with appropriate documentation - Add testing to verify catching and correctly handling these edge cases
bowang007
pushed a commit
that referenced
this pull request
Apr 28, 2023
bowang007
pushed a commit
that referenced
this pull request
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
remove_unnecessary_castsreplaces both tensors in anaten::divcall with the corresponding scalars, and the rounding mode (third argument) is specified, the schema becomes invalidaten::Int(aten::div(...)), for "trunc" oraten::floordiv(...)for "floor"Fixes #1780
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: